This project is archived and is in readonly mode.

#1505 ✓resolved
Paweł Kondzior

Allow to unmoemoize only specific method(s)

Reported by Paweł Kondzior | December 2nd, 2008 @ 12:04 PM | in 2.x

This patch will allow to unmemoize only specific methods, right now when you want to unmemoize something in instance of method, you must use unmemoize_all

Comments and changes to this ticket

  • josh

    josh December 3rd, 2008 @ 02:18 AM

    • State changed from “new” to “open”
    • Assigned user set to “josh”

    I would recommend using the reload API instead of just clearing its cache.

    foo(:reload) # or

    Am I missing another use case?

  • Paweł Kondzior

    Paweł Kondzior December 3rd, 2008 @ 08:39 AM

    In this example foo is memoized method ?

    Using unmemoize(:method1, :method2) can be useful when we want to override attribute setter which depends on our memoized methods, for AR we can override reload to unmemoize_all, but in such example we clear whole cache, even if we only need to clear one method.

    class Foo < ActiveRecord::Base
      extend ActiveSupport::Memoizable
      def is_something_valid?
        if self.only_locations && Location.find(:all, :conditions => ['some_conditions']
      def only_locations=(value)
  • Paweł Kondzior

    Paweł Kondzior December 3rd, 2008 @ 08:43 AM

    Internally in Memoizable::Freezable i think it will be DRY to not repeat same code in unmemoizel_all and unmemoize. Obviously i don't know what internal policy Rails have, and it is really necessary to be DRY fundamentalist here.

  • josh

    josh December 3rd, 2008 @ 03:18 PM

    You sold me.

    A few things though,

    1. Needs test case
    2. Like you said, build unmemoize_all on top of it. Maybe even make unmemoize_all just unmemoize(:all)
    3. I know we'd be changing old apis, but unmemoize isn't intention revealing. It sounds like is doing the opposite of the memoize helper and removing the ability permanently. I'd prefer something like "flush_cache".
  • Repository

    Repository December 3rd, 2008 @ 04:57 PM

    • State changed from “open” to “resolved”

    (from [761a633a9c0a45d76ef3ed10da97e3696c3ded79]) Add Memoizable#flush_cache to clear the cache of a specific method [#1505 state:resolved]

  • Paweł Kondzior

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket


Referenced by