#1559 [Patch] OrderedHash does not sync it's @keys after mutating operations. - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1559 ✓committed

[Patch] OrderedHash does not sync it's @keys after mutating operations.

Reported by Eloy Duran | December 11th, 2008 @ 01:19 PM | in 2.x

Here's a patch which fixes this for #delete_if, #reject!, and #reject.

This probably holds true for any other mutating method, I haven't gone through them all except these which I needed.

If the recent change to OrderedHash, to subclass Hash, was a speed improvement; would it still be so after fixing all mutating methods like these?

Michael Koziarski December 11th, 2008 @ 01:34 PM
- State changed from “new” to “resolved”
Applied, cheers!
Frederick Cheung December 11th, 2008 @ 03:22 PM
Speed things up a little and cover some of the other mutators
- ordered_hash_additions.patch 4 KB
Frederick Cheung December 12th, 2008 @ 10:20 AM
- State changed from “resolved” to “open”
Repository December 12th, 2008 @ 06:19 PM
- State changed from “open” to “committed”
(from [6eed6cf5c6db0dbf96c1c2756eb946f54277a0cb]) Make delete_if/reject faster and fix other mutators

[#1559 state:committed]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/co...
Repository December 15th, 2008 @ 02:38 PM
(from [4dcd8f01afe5800baa67bbdf72832afb0d627755]) Make delete_if/reject faster and fix other mutators

[#1559 state:committed]

Signed-off-by: Jeremy Kemper jeremy@bitsweat.net http://github.com/rails/rails/co...

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>