render :layout with block and multiple yields renders twice

Also, in _common.html.erb, if instead of <%= yield :top %> I use (the deprecated) <%= @content_for_top %> it works as expected.

There's also a problem with passing a layout to render a collection with partials.
The layout is applied around the whole collection (as expected), but the whole thing (layout plus collection partials) gets rendered as many times as the items in the collection.

Here's a quick patch that should fix both problems...

I've run into this problem running ruby1.9.1 and rails 3 beta. I'm trying to use two "render :layout do [something] end" inside each other.

I am not able to reproduce this problem in 2-3-stable. However Aditya was able to recreate this problem just 3 days ago. Not sure what's going on.

Can someone else try?

I can reproduce the output described by Jeff with Rails 2.3.8, Ruby 1.8.7 and 1.9.2.

Is this an issue on master too? or only 2-3-stable?

masone has reproduced this on 2.3.8 on July 18th, can you try it on 2-3-stable from git?.
And can someone provide a patch

I've created a sample app that may or may not be this issue but is very similar. I'm not sure that the yields are causing the failures.

http://github.com/jgeiger/double_render_bug

Isn't this because actionpack-3.0.0\lib\action_view\render\rendering.rb is:

def render(options = {}, locals = {}, &block)
  case options
  when Hash
    if block_given?
      _render_partial(options.merge(:partial => options[:layout]), &block)

where it should be?

def render(options = {}, locals = {}, &block)
  case options
  when Hash
    if block_given?
      options.merge!(:partial => options[:layout])
      options.delete(:layout)
      _render_partial(options, &block)

This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.