Rails always resend the same cookie with active_record sessions

Possibly??

module ActionController #:nodoc:
  module Cookies

  protected
    # Returns the cookie container, which operates as described above.
    def cookies
-      @cookies ||= CookieJar.new(self)
+      CookieJar.new(self)
    end
  end
end

Any updates here? Can somebody please try and verify if this is still an issue on master.

Hi,

I can verify that it still apply to current master. I was working on it, but didn't finish it.

Will come back and provide patch for it soon.

What always resending the cookie is an issue?

Sorry! For ActiveRecord store, since the cookie only contains the session_id, it does not make sense to send the same cookie every time. Yes, this should be fixed!

Ok, so I've patched the abstract_store to check that the session_id value has been changed or not. If not, then it won't call the []= of cookie jar, which was resulted in sending the cookie back to user again.

Noted that I also checked that the expired is not set. If it does, it will always resend the session_id cookie regardless of whether it's already set or not, to extend the expire time.

I've attach the patch that cleanly apply on master. Patch for 2-3-stable hopefully will come soon.

(from [f8f365346ec55ef388eaa43e30bd7629c375d274]) Make sure that Rails doesn't resent session_id cookie over and over again if it's already there [#2485 Rails always resend the same cookie with active_record sessions state:resolved]

This apply to only Active Record store and Memcached store, as they both store only the session_id, which will be unchanged, in the cookie.

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/f8f365346ec55ef388eaa43e30bd76...