#2810 with_scope should accept and use order option - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2810 ✓invalid

with_scope should accept and use order option

Reported by Emilio Tagua | June 16th, 2009 @ 11:56 PM | in 3.x

This patch adds support for order and nested orders when using with_scope.

Tests included, all tests passing on MySQL, Sqlite3 and Postgresql.

This will probably also close the following ticket:

https://rails.lighthouseapp.com/projects/8994-ruby-on-rails/tickets...

add_order_option_to_with_scope.diff 6.6 KB

Comments and changes to this ticket

You flagged this item as spam.
duncanbeevers September 17th, 2009 @ 11:48 PM
+1

I think this fits best with people's expectations of how scopes should compose.
Jeremy Kemper May 4th, 2010 @ 06:48 PM
- Milestone changed from “2.x” to “3.x”
[bulk edit]
Dan Pickett May 9th, 2010 @ 07:12 PM
- Tag changed from “activerecord, patch, with_scope” to “activerecord, bugmash, patch, with_scope”
Jeff Kreeftmeijer May 15th, 2010 @ 05:26 PM
+1

Applies cleanly to master and tests pass. Nice addition! :)
You flagged this item as spam.
Anil Wadghule May 15th, 2010 @ 06:13 PM
I am trying to apply this patch with 'git am < patch.diff'. Patch is not getting applied for me http://pastie.org/961761. Am I missing something here?
You flagged this item as spam.
Enrico Bianco May 15th, 2010 @ 07:01 PM
I'm having the same trouble applying this patch. The places where it fails don't even seem to be functional changes. Trying to edit the patch...
You flagged this item as spam.
Craig Krigsman May 15th, 2010 @ 07:09 PM
I'm unable to apply this patch either.

Base.rb 401 is a comment apply error.
.rb wrong line apply location.

Working on revised diff.

Error output.

error: patch failed: activerecord/lib/active_record/base.rb:401
error: activerecord/lib/active_record/base.rb: patch does not apply
error: patch failed: activerecord/test/cases/method_scoping_test.rb:657
error: activerecord/test/cases/method_scoping_test.rb: patch does not apply
You flagged this item as spam.
Enrico Bianco May 15th, 2010 @ 07:14 PM
Seems the with_scope method has changed considerably since this patch. Possibly some logic moved into arel that used to be in ActiveRecord::Base?
You flagged this item as spam.
Senthil May 15th, 2010 @ 07:19 PM
I also got a very similar set of error while applying the patch http://gist.github.com/402327
Rizwan Reza May 15th, 2010 @ 07:40 PM
- Tag changed from “activerecord, bugmash, patch, with_scope” to “activerecord, patch, with_scope”
- State changed from “new” to “invalid”
I am closing it. We can reopen if the issue still exists.
You flagged this item as spam.
Craig Krigsman May 15th, 2010 @ 07:53 PM
- Tag changed from “activerecord, patch, with_scope” to “activerecord, bugmash, patch, with_scope”
-1 I would suggest this patch is no longer relevant to rails 3 since with_scope has been removed. http://m.onkey.org/2010/1/22/active-record-query-interface
Ryan Bigg November 8th, 2010 @ 01:54 AM
- Tag cleared.
- Importance changed from “” to “Low”
Automatic cleanup of spam.