Rails Ruby on Rails → 3.0.2

Comments and changes to this ticket

• You flagged this item as spam.
  

  kmpm July 28th, 2009 @ 03:39 PM

  missed adding the patch

  • test_foxy_fixtures_with_module_models.diff 3.2 KB

• You flagged this item as spam.
  

  Kane August 16th, 2009 @ 03:13 AM

  Hey,

  I took your tests modifed them to reflect #1976 so fixtures are in subfolders representing the namespace for organisational purpose. generators should now generate the fixtures and models (no namespace in tablename) correctly.

  also modified fixtures:load but no clue how to test it.

• 

  José Valim August 16th, 2009 @ 08:37 AM

  @Kane, awesome! I have some small feedback about the patch:

  1) This code repeats in three parts in the patch:

    namespace = Fixtures.extract_namespace(fixture_file)
    class_name = Fixtures.build_class_name(table_name, namespace)
    Fixtures.try_to_load_dependency(class_name.underscore)
    class_name if Fixtures.class_exists? class_name
  

  Could you put it in its own method?

  2) There is a "debug" line in the patch:

  if table_names.include?'albums'
  puts table_names.inspect
  puts class_names.inspect
  end
  

  3) One question, why do you have split, prune and join the namespace?

  namespace = namespace.split('/')[0..-2].join('/')
  

  4) And there is no need to add the generators changes on this patch. We will do that in #1976. :)

  Good work, thanks!

• You flagged this item as spam.
  

  Kane August 16th, 2009 @ 07:48 PM

  thanks for the feedback

  i removed all generator specific changes and the debug lines.
  also made refactoring to reduce the repeating code. and to 3) i assume you mean line 510, its to remove the classname.

  • namespaced_fixtures.diff 11.8 KB

• You flagged this item as spam.
  

  Kane August 28th, 2009 @ 12:39 AM

  • Assigned user set to “Jeremy Kemper”

• You flagged this item as spam.
  

  gjeudy December 3rd, 2009 @ 10:19 PM

  Is there a workaround for this bug? using set_fixture_class doesn't help in my case. I'm trying the same thing a bidirectional one-to-many association with foxy fixtures.

• 

  Andrew White April 14th, 2010 @ 06:30 PM

  Attached patch adds support for namespaced model fixtures. Fixture name uses '/' to specify the namespace, so to use in a test you'd do something like this:

  class Admin::AccountTest < ActiveSupport::TestCase
    fixtures :"admin/accounts"
  
    def test_something
      assert admin_accounts(:fixture_name)
    end
  end
  

  Code isn't as clean as I'd like but I'm guessing you don't want a major refactoring of fixtures at this point. It should be possible to backport this to 2-3-stable if desired as soon as the backport of #2283 is applied.

  I was in two minds over stripping the namespace off the fixture accessor - what do you think?

  • 0001-fix-nested-model-fixtures.diff 5.9 KB
• 

  José Valim April 14th, 2010 @ 08:06 PM

  • Assigned user changed from “Jeremy Kemper” to “José Valim”
  • Milestone cleared.
• 

  Andrew White April 15th, 2010 @ 06:12 AM

  It would help if I included the fixtures and models. Got burned (again!) by the fact that git commit -a doesn't include new files.

  • 0002-fix-nested-model-fixtures.diff 7.9 KB
• 

  José Valim April 25th, 2010 @ 12:23 PM

  Hey Andrey, sorry for the delay but the patch does not apply anymore. Can you please rebase it?
  Also, what is the deal with #2283? It's marked as resolved, but the problem still persists for you?

  Finally, I'm -1 in back porting these changes to 2.3 since I don't want to make significative changes and break plugins in a maintenance branch.

• 

  Andrew White April 25th, 2010 @ 02:46 PM

  Rebased patch attached.

  The issue with #2283 is that I backported the patch but it's never been applied to 2-3-stable. Since I was asked to backport #4032 I thought there was an attempt to get nested models working the same in 2.3 and 3.0, which is why I suggested backporting this patch.

  • 0003-fix-nested-model-fixtures.diff 7.9 KB
• 

  Repository April 25th, 2010 @ 03:05 PM

  • State changed from “new” to “resolved”

  (from [8ec085bf1804770a547894967fcdee24087fda87]) Support fixtures for namespaced models [#2965 state:resolved]

  Signed-off-by: José Valim jose.valim@gmail.com
  http://github.com/rails/rails/commit/8ec085bf1804770a547894967fcdee...

• 

  José Valim April 25th, 2010 @ 03:06 PM

  Awesome, thanks for the patch! Imho, there is no need to backport for 2-3-stable. If anyone else is interested, they can apply it.

• 

  Jeremy Kemper October 15th, 2010 @ 11:01 PM

  • Milestone set to “3.0.2”
  • Importance changed from “” to “”

  [bulk edit]