#2966 to_xml generated <foo type="binary"> tags not accepted by from_xml - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2966 ✓resolved

to_xml generated <foo type="binary"> tags not accepted by from_xml

Reported by John Franklin | July 28th, 2009 @ 08:06 PM | in 3.0.2

Converting binary data to XML creates ... tags. Sending the same tag back to rails fails to decode the base64 because the from_xml doesn't acknowledge the type="binary" attribute. It expects a type="binaryBase64" attribute, instead.

The attached patch adds support for a type="binary" with an optional encoding="base64". If the encoding attribute is absent, the data is considered unencoded.

base64.diff 1.9 KB

Comments and changes to this ticket

You flagged this item as spam.
John Franklin July 28th, 2009 @ 08:09 PM
Stupid lighthouse. Let's try this again:

The tags noted in the bug should be:
...
You flagged this item as spam.
John Franklin July 28th, 2009 @ 08:11 PM
Grr... (If only there were a preview button next to the "update ticket" button)

<mydata type="binary" encoding="base64">...</mydata>
You flagged this item as spam.
John Franklin July 28th, 2009 @ 08:24 PM
- Tag changed from “binary, from_xml, xml” to “binary, from_xml, patch, xml”
CancelProfileIsBroken August 7th, 2009 @ 02:37 PM
- Tag changed from “binary, from_xml, patch, xml” to “binary, bugmash, from_xml, patch, xml”
You flagged this item as spam.
Josh Nichols August 9th, 2009 @ 06:59 PM
- Tag changed from “binary, bugmash, from_xml, patch, xml” to “binary, bugmash, from_xml, patch, verified, xml”
+1, because without this patch, the attribute gets serialized as 'true'.

Verified the patch applies and works as intended.
You flagged this item as spam.
Jörg B. August 18th, 2009 @ 11:20 AM
+1 ... tested it aswell
Rizwan Reza January 20th, 2010 @ 11:38 AM
- State changed from “new” to “verified”
- Tag changed from “binary, bugmash, from_xml, patch, verified, xml” to “binary, from_xml, patch, verified, xml”
- Milestone cleared.
Rizwan Reza January 20th, 2010 @ 11:39 AM
This applies cleanly to master.
Rizwan Reza March 26th, 2010 @ 08:48 AM
- Assigned user set to “José Valim”
Repository March 26th, 2010 @ 02:52 PM
- State changed from “verified” to “resolved”
(from [c7cc9583689d63d342983d739ccf5c4e94233a48]) Add support for a type=binary with an optional encoding=base64. If the encoding attribute is absent, the data is considered unencoded. [#2966 state:resolved] http://github.com/rails/rails/commit/c7cc9583689d63d342983d739ccf5c...
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
- Importance changed from “” to “Low”
[bulk edit]