This project is archived and is in readonly mode.

#3242 ✓resolved

Nokogiri XmlMini code is broken on 2-3-stable

Reported by CancelProfileIsBroken | September 21st, 2009 @ 11:55 PM | in 2.3.6

ActiveSupport::XmlMini_Nokogiri#parse is busted on 2-3-stable because it uses "string" to name a parameter and later tries to refer to this same parameter as "data". As a result, a dozen tests fail.

  • Failures are not detected on CI because Nokogiri isn't installed on CI server
  • Code in master is different (and good) due to major rewrites

Attached patch fixes 2-3-stable to work properly if Nokogiri is installed

Comments and changes to this ticket

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href=""></a>

People watching this ticket


Referenced by