#3353 accepts_nested_attributes, validates_presence_of - saves associated model - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3353 ✓committed

accepts_nested_attributes, validates_presence_of - saves associated model

Reported by qoobaa | October 8th, 2009 @ 03:32 PM | in 2.3.10

We've got two model classes:

class User < ActiveRecord::Base
  has_many :posts
  after_save { puts "after_save" }
end

class Post < ActiveRecord::Base
  belongs_to :user
  validates_presence_of :user
  accepts_nested_attributes_for :user
end

>> User.create!
after_save
>> Post.create!(:user => User.first)
after_save
=> #<Post id: 1, user_id: 1, created_at: "2009-10-08 14:02:04", updated_at: "2009-10-08 14:02:04">
>> Post.first.touch
after_save
=> true

We're executing after_save callback by touching associated post model. It's totally unexpected behavior. It's quite similar to #2578, but the patch doesn't solve the problem.

Comments and changes to this ticket

Eloy Duran December 30th, 2009 @ 07:54 PM
- Milestone set to “2.3.6”
- Assigned user set to “Eloy Duran”
Rizwan Reza May 16th, 2010 @ 02:41 AM
- Tag set to “bugmash”
[bulk edit]
Jeremy Kemper May 23rd, 2010 @ 05:54 PM
- Milestone changed from “2.3.6” to “2.3.7”
[bulk edit]
Jeremy Kemper May 24th, 2010 @ 09:40 AM
- Milestone changed from “2.3.7” to “2.3.8”
[bulk edit]
Jeremy Kemper May 25th, 2010 @ 11:45 PM
- Milestone changed from “2.3.8” to “2.3.9”
[bulk edit]
Eloy Duran July 8th, 2010 @ 08:39 AM
- Assigned user changed from “Eloy Duran” to “José Valim”
- Importance changed from “” to “”
You flagged this item as spam.
Subba July 14th, 2010 @ 10:08 AM
I found the fix for this
below is the reason why children save if parent saves(even when they are not changed)
activerecord/lib/active_record/autosave_association.rb at line 375
```
  saved = association.save(:validate => !autosave) if association.new_record? || autosave
```
i am providing patch for this.
this is currently happening in rails3 and rails23stable.
so i am providing two different patches.
- 3353_rails2_3_stable_patch.diff 3.1 KB
- 3353_rails3_patch.diff 3 KB
Repository July 18th, 2010 @ 10:36 AM
- State changed from “new” to “resolved”
(from [4a0d7c1a439c6ad8d35bf514761824e51fa07df2]) save on parent should not cascade to child unless child changed [#3353 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/4a0d7c1a439c6ad8d35bf514761824...
José Valim July 18th, 2010 @ 10:37 AM
- State changed from “resolved” to “open”
Patch no longer applied for 2-3-stable. Could you please rebase? Thanks!
You flagged this item as spam.
Subba July 21st, 2010 @ 11:16 AM
Jose due to the above patch me below case is not working.
changes to grand children no longer works if parent is not changed.
as saving children is one of the callback.
would you rollback above patch.
is there anyway to detect changes to children
```
@ship = Ship.create(:name => 'Nights Dirty Lightning')
@pirate = @ship.create_pirate(:catchphrase => "Don' botharrr talkin' like one, savvy?")
@parrot = @pirate.parrots.create!(:name => 'Posideons Killer')
@parrot.name = "NewName"
@ship.save
assert_equal 'NewName', @parrot.reload.name
```
José Valim July 21st, 2010 @ 11:24 AM
Do you want me to revert the patch?
You flagged this item as spam.
Subba July 21st, 2010 @ 11:30 AM
yes.
Repository July 21st, 2010 @ 01:52 PM
(from [01add55d6a6a67fb487afa040998575111511b6d]) Revert "save on parent should not cascade to child unless child changed [#3353 state:open]"

Please check Lighthouse for more information.

This reverts commit 4a0d7c1a439c6ad8d35bf514761824e51fa07df2.
http://github.com/rails/rails/commit/01add55d6a6a67fb487afa04099857...
Jeremy Kemper August 30th, 2010 @ 02:28 AM
- Milestone changed from “2.3.9” to “2.3.10”
[bulk edit]
Repository December 13th, 2010 @ 04:14 PM
- State changed from “open” to “committed”
(from [658bb4fa25db0b3f61bfb64028274f2365cad506]) Only call save on belongs_to associations if the record has changed or any nested associations have changed (resolves #3353)

Signed-off-by: José Valim jose.valim@gmail.com
https://github.com/rails/rails/commit/658bb4fa25db0b3f61bfb64028274...
Repository December 15th, 2010 @ 08:40 PM
(from [bda16eb0920780509467bcf051d1a01639357903]) Only call save on belongs_to associations if the record has changed or any nested associations have changed (resolves #3353)

Signed-off-by: José Valim jose.valim@gmail.com
https://github.com/rails/rails/commit/bda16eb0920780509467bcf051d1a...