#3468 Some assertions for the testing of ActionView::TestCase are worthless - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3468 ✓resolved

Some assertions for the testing of ActionView::TestCase are worthless

Reported by Chris Hapgood | November 6th, 2009 @ 10:35 PM | in 2.3.6

In view/test_case_test.rb there are several assertions of this form:

assert 'Holla!', from_shared_helper

How useful is that?!

Attached is a patch that makes more meaningful assertions. For example:

assert_equal 'Holla!', from_shared_helper

The patch applies to 2-3-stable.

For those following along, the good news is that after strengthening the assertions, all tests still pass. At least on 2-3-stable.

You flagged this item as spam.
Chris Hapgood November 6th, 2009 @ 10:38 PM
Looks like I doubled up the original patch. Here is the proper one.
- fix_worthless_assertions.diff 1.8 KB
Eloy Duran November 6th, 2009 @ 11:01 PM
- State changed from “new” to “verified”
- Milestone set to “2.3.6”
- Assigned user set to “Eloy Duran”
Yup, they're worthless. Applied them in our repo, which will be merged in the main repo in a short while. http://github.com/Fingertips/rails/commit/df9a47e4b8f12a8ecf3001a93...

Gonna look at your other ticket now, thanks.
Repository November 8th, 2009 @ 10:17 PM
- State changed from “verified” to “resolved”
(from [df9a47e4b8f12a8ecf3001a93ab7ba5cefdc9467]) Make some assertions in the ActionView::TestCase tests actually do something.

[#3468 state:resolved]

Signed-off-by: Eloy Duran eloy.de.enige@gmail.com
http://github.com/rails/rails/commit/df9a47e4b8f12a8ecf3001a93ab7ba...
Repository November 8th, 2009 @ 10:17 PM
(from [b43964d6061f4a31320906172f763dd3dd188f4d]) Make some assertions in the ActionView::TestCase tests actually do something.

[#3468 state:resolved]

Signed-off-by: Eloy Duran eloy.de.enige@gmail.com
http://github.com/rails/rails/commit/b43964d6061f4a31320906172f763d...

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>