#3716 [PATCH] test_flash method it's failing with error on ruby1.9.1 - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#3716 ✓resolved

[PATCH] test_flash method it's failing with error on ruby1.9.1

Reported by Santiago Pastorino | January 17th, 2010 @ 02:18 AM


santiago@debian:~/Documentos/WyeWorks/Proys/rails/actionpack$ rake test
(in /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack)
Loaded suite /usr/lib/ruby/1.9.1/rake/rake_test_loader
Started
..............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................E...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................P.P.P.P....................................................................................................................................................................................................................................................P....................................................................................................................................................................................................................................................................................................................................................................................................................................................
Finished in 34.850692 seconds.

  1) Error:
test_flash(FlashIntegrationTest):
ArgumentError: Anonymous modules have no name to be referenced by
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/dependencies.rb:601:in `to_constant_name'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/dependencies.rb:407:in `qualified_name_for'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/dependencies.rb:115:in `rescue in const_missing'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/dependencies.rb:105:in `const_missing'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/test/controller/flash_test.rb:223:in `block (2 levels) in with_test_route_set'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/routing/route_set.rb:247:in `instance_exec'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/lib/action_dispatch/routing/route_set.rb:247:in `draw'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/test/controller/flash_test.rb:222:in `block in with_test_route_set'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/test/abstract_unit.rb:131:in `with_routing'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/test/controller/flash_test.rb:221:in `with_test_route_set'
    /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/test/controller/flash_test.rb:208:in `test_flash'
    /home/santiago/Documentos/WyeWorks/Proys/rails/vendor/gems/ruby/1.9.1/gems/mocha-0.9.8/lib/mocha/integration/mini_test/version_131_and_above.rb:26:in `run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:32:in `block in run'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/callbacks.rb:432:in `_run_setup_callbacks'
    /home/santiago/Documentos/WyeWorks/Proys/rails/activesupport/lib/active_support/testing/setup_and_teardown.rb:31:in `run'

2621 tests, 12053 assertions, 0 failures, 1 errors, 0 skips

Pending Cases:
block in  at /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/test/dispatch/response_test.rb, line 187
block in  at /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/test/dispatch/response_test.rb, line 168
block in  at /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/test/dispatch/response_test.rb, line 223
block in  at /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/test/dispatch/response_test.rb, line 205
test_file_stream at /home/santiago/Documentos/WyeWorks/Proys/rails/actionpack/test/controller/send_file_test.rb, line 54
rake aborted!
Command failed with status (1): [/usr/bin/ruby1.9.1 -Ilib:test "/usr/lib/ru...]

(See full trace by running task with --trace)

Comments and changes to this ticket

Santiago Pastorino January 17th, 2010 @ 02:21 AM
with_test_route_set is the problem when referring TestController inside set.draw and SessionKey and surely SessionSecret.

the flow reaches raise ArgumentError, "Anonymous modules have no name to be referenced by" if desc.name.blank? on ActiveSupport::Dependencies.to_constant_name
Rizwan Reza January 17th, 2010 @ 03:19 AM
- Tag changed from “failing, flash, tests” to “3.0, failing, flash, tests”
- Assigned user set to “josh”
Santiago Pastorino January 17th, 2010 @ 03:42 AM
This solves the bug
- flash_test_fixed.patch 1.1 KB
Rizwan Reza January 17th, 2010 @ 07:46 AM
- Tag changed from “3.0, failing, flash, tests” to “3.0, failing, flash, patch, review, tests”
- Title changed from “test_flash method it's failing with error on ruby1.9.1” to “[PATCH] test_flash method it's failing with error on ruby1.9.1”
+1 Verified. This patch applies cleanly on master.
José Valim January 17th, 2010 @ 03:55 PM
- Assigned user changed from “josh” to “José Valim”
Repository January 17th, 2010 @ 03:58 PM
(from [5a6596787b9489c62d149b61935057cee3dcf61a]) Module lookup issue on flash_test using ruby 1.9 solved [#3716 status:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/5a6596787b9489c62d149b61935057...
José Valim January 17th, 2010 @ 03:58 PM
- State changed from “new” to “resolved”