Rails Ruby on Rails

Comments and changes to this ticket

• You flagged this item as spam.
  

  Ryan Garver June 16th, 2008 @ 06:06 PM

  I almost want it to be invalidates_format_of

• You flagged this item as spam.
  

  Ken Collins June 16th, 2008 @ 06:09 PM

  Yes... I like that name better. Too +1

• You flagged this item as spam.
  

  Brennan Dunn June 16th, 2008 @ 06:31 PM

  Agreed. I wasn't feeling creative enough to come up with a decent method name ;-)

• You flagged this item as spam.
  

  Alex MacCaw June 16th, 2008 @ 07:01 PM

  +1

• 

  Pratik August 3rd, 2008 @ 02:52 PM

  • Assigned user set to “Pratik”
  • State changed from “new” to “incomplete”
  • Tag set to “activerecord, patch, tested”

  I don't think we need a new validation method here. Could just add a new key to validates_format_of

  validates_format_of :permalink, :without => /admin/i
  

• You flagged this item as spam.
  

  Elliot Winkler June 29th, 2009 @ 05:11 AM

  I think validates_format_of :permalink, :not => /admin/i reads a bit better. We ended up patching Rails a while back to support this, so I've prepped this into a proper patch, complete with tests, which I've attached.

  • validates_format_of_not.patch 6.7 KB
• 

  CancelProfileIsBroken August 7th, 2009 @ 02:16 PM

  • Tag changed from “activerecord, patch, tested” to “activerecord, bugmash, patch, tested”

• You flagged this item as spam.
  

  Peer Allan August 10th, 2009 @ 02:08 AM

  Verified that the patch does not apply to 2-3-stable or master. The patch would have to be manually redone for master due to the refactor to ActiveModel

• You flagged this item as spam.
  

  Peer Allan August 10th, 2009 @ 03:28 AM

  Updated patch for 2-3-stable

  • validate_format_of_not.diff 6.7 KB

• You flagged this item as spam.
  

  Peer Allan August 10th, 2009 @ 03:49 AM

  Patch for master with tests, integrated into ActiveModel

  • validates_format_of_not_to_master.diff 6.8 KB
• 

  Rizwan Reza August 10th, 2009 @ 03:56 AM

  • Tag changed from “activerecord, bugmash, patch, tested” to “activerecord, bugmash, patch”

  not reproducible

  +1 I really like the feature.

  I am having problems implementing this to current master. The file to implement this activerecord/lib/active_model/validations/format.rb.

• You flagged this item as spam.
  

  Elliot Winkler August 10th, 2009 @ 02:38 PM

  Are all validations in ActiveModel, is that how it works now?

• You flagged this item as spam.
  

  Elliot Winkler August 10th, 2009 @ 02:47 PM

  Also I believe Peer meant for the first patch to apply to 2-3-stable and the second to apply to master since I'm guessing ActiveModel has been finished out more in master.

• You flagged this item as spam.
  

  Peer Allan August 10th, 2009 @ 03:18 PM

  That is exactly right, Elliot. The refactor to ActiveModel meant 2 patches, one for 2-3-stable (the first one) and one for master (the second one).

• 

  Pratik August 10th, 2009 @ 03:26 PM

  I don't think this belongs to 2.3. I've applied it to the master using :without option.

  Thanks!

• 

  Repository August 10th, 2009 @ 03:29 PM

  • State changed from “incomplete” to “resolved”

  (from [cccb0e6b9327fb562b72007a012933c9c61a33fa]) Add validates_format_of :without => /regexp/ option [Elliot Winkler, Peer Allan]

  [#430 state:resolved]

  Example :

  validates_format_of :subdomain, :without => /www|admin|mail/
  

  Signed-off-by: Pratik Naik pratiknaik@gmail.com
  http://github.com/rails/rails/commit/cccb0e6b9327fb562b72007a012933...