This project is archived and is in readonly mode.
[Patch] Can't install plug in on Windows
-
Anil Wadghule
Attached the patch for the issue. Basically fixed regex to determine Windows environment and made consistent with other uses. This patch is against 2-3-stable branch. Can somebody change milestone of this ticket to 2.3.6?
-
Anil Wadghule
my bad, fixed the patch now.
-
Anil Wadghule
- Title changed from Can't install plug in on Windows to [Patch] Can't install plug in on Windows
-
José Valim
- State changed from new to open
- Assigned user set to José Valim
Could you please check if this is also broken in Rails 3.0?
-
Anil Wadghule
The above issue does not exist for Rails 3 on Windows machine. See this pastie http://pastie.org/912838.
This patch is created against 2-3-stable repository of Rails.
I have created separate ticket with patch for Rails 3 (for consistent usage of RUBY_PLATFORM regex for Windows). #4345 [Patch] Make RUBY_PLATFORM windows regex consistent. But that patch is not related to the current issue.
-
Anil Wadghule
- Tag changed from git, install, plugin, script, windows to git, install, patch, plugin, script, windows
-
Repository
- State changed from open to resolved
(from [c69dc1afaa06c956624e20528adb2540fda0eb18]) Fix for plugin not getting installed on Windows environment [#4320 [Patch] Can't install plug in on Windows state:resolved]
Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/c69dc1afaa06c956624e20528adb25... -
José Valim
Thanks Anil, I just applied both patches!
I'm sure the Rails community using Windows appreciate your efforts!
