#4389 Redirect broken when using namespaces in routes.rb - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4389 ✓resolved

Redirect broken when using namespaces in routes.rb

Reported by wildchild | April 14th, 2010 @ 03:14 AM

In order to be redirected to /admin/dashboard from /admin I defined the following routes:

namespace :admin do
  match "/", :to => redirect("/admin/dashboard")
  match "/dashboard", :to => "dashboard#index", :as => :dashboard
end

It results in: "ActionController::RoutingError (uninitialized constant Admin::Controller):"

Different one works as expected:

match "/admin", :to => redirect("/admin/dashboard")
namespace :admin do
  match "/dashboard", :to => "dashboard#index", :as => :dashboard
end

But I can't relax, it seems something wrong in the router internals, right?

Comments and changes to this ticket

Ryan Bigg April 14th, 2010 @ 04:13 AM
Could you please submit a failing test for this?
You flagged this item as spam.
wildchild April 14th, 2010 @ 05:15 AM
With pleasure.
- 0001-add-failing-test-case-to-show-buggy-redirect.patch 1.3 KB
You flagged this item as spam.
Tyler Hunt June 22nd, 2010 @ 04:19 PM
This also fails with the same error when using #root:
```
namespace :admin do
  root :to => redirect('/admin/companies')
  resources :companies
end
```
Andrew White June 24th, 2010 @ 10:55 AM
Attached patch fixes this issue.

I've written it so that the redirect path is namespaced which seems logical to me:
```
namespace :admin do
  root :to => redirect('/companies')
  resources :companies
end
```
If you don't want it this way then let me know and I'll change the patch.
- 0001-fix-namespaced-redirects.diff 2.4 KB
You flagged this item as spam.
Damien MATHIEU June 24th, 2010 @ 11:06 AM
If the redirect path is namespaced, it mean we can't redirect to a path outside of the current namespace. That doesn't seem so logical to me.
Andrew White June 24th, 2010 @ 11:16 AM
I thought about that and you'd handle that situation like this:
```
  match '/admin', :to => redirect('/other')
```
To me it seems everything within a namespace block should be namespaced.
Andrew White June 24th, 2010 @ 11:51 AM
- State changed from “new” to “open”
Updated patch which doesn't namespace redirect path
- 0002-fix-namespaced-redirects.diff 2 KB
Repository June 24th, 2010 @ 12:28 PM
- State changed from “open” to “resolved”
(from [df15ba7eadb180626474161741f901e675f517ce]) Fix namespaced redirects [#4389 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/df15ba7eadb180626474161741f901...