#4600 Hash#index is deprecated at 'rake routes' - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#4600 ✓resolved

Hash#index is deprecated at 'rake routes'

Reported by Sasha Koss | May 15th, 2010 @ 12:46 PM

In 'rake routes' command used deprecated Hash#index (in 1.9.x):

http://github.com/rails/rails/blob/master/railties/lib/rails/tasks/...

  name = Rails.application.routes.named_routes.routes.index(route).to_s

to fix it we should use Hash#key in 1.9.x (in 1.8.7 'key' method is not exist)

Comments and changes to this ticket

You flagged this item as spam.
Sasha Koss May 15th, 2010 @ 01:10 PM
- Tag changed from “rake routes, 1.9, bugmash, rails3” to “rake routes, 1.9, bugmash, patch, rails3”
I attached patch to this ticket
You flagged this item as spam.
Sasha Koss May 15th, 2010 @ 02:18 PM
In attach updated diff with valid commit name *
- fix_rake_routes_hash_index_deprecated.diff 1.2 KB
You flagged this item as spam.
Anil Wadghule May 15th, 2010 @ 06:37 PM
+1

Looks fine to me. Works find for 1.8.7 and 1.9.2.
You flagged this item as spam.
Colin Casey May 15th, 2010 @ 07:32 PM
+1 Works on 1.9.1
You flagged this item as spam.
Enrico Bianco May 15th, 2010 @ 10:24 PM
+1

I've tested this in 1.8.7, 1.9.1, and 1.9.2-head by pushing it to a separate branch of my fork of rails and bringing it in to a sample application via bundler. No problems running 'rake routes' across all tested rubies.
You flagged this item as spam.
Sasha Koss May 16th, 2010 @ 03:31 AM
- Assigned user set to “José Valim”
You flagged this item as spam.
Bastes May 16th, 2010 @ 01:25 PM
+1 On 1.8.7
Repository May 16th, 2010 @ 01:35 PM
- State changed from “new” to “resolved”
(from [3e84ea014e9f4d0f8d302c9bf8ad04240eec2804]) Fix Hash#index deprecated warning in 1.9.x [#4600 state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/3e84ea014e9f4d0f8d302c9bf8ad04...
José Valim May 16th, 2010 @ 05:03 PM
- Tag changed from “rake routes, 1.9, bugmash, patch, rails3” to “rake routes, 1.9, patch, rails3”