Rails Ruby on Rails → 3.0.2

Comments and changes to this ticket

• You flagged this item as spam.
  

  Carlos Antonio da Silva May 15th, 2010 @ 05:06 PM

  • Tag changed from “rails 3.0.0.beta3” to “rails 3.0.0.beta3, action_view, number_helper”

  Just tested here following the same steps, using both Ruby 1.8.7-p249 and 1.9.2-head with Rails 3.0.0.beta3 in a fresh app, nothing wrong.

  ruby-1.8.7-p249 > foo.number_to_currency(101.00)
   => "$101.00"
  

• 

  Santiago Pastorino May 16th, 2010 @ 12:11 AM

  • Tag changed from “rails 3.0.0.beta3, action_view, number_helper” to “rails 3.0.0.beta3, action_view, bugmash, number_helper”
• 

  Santiago Pastorino May 16th, 2010 @ 12:12 AM

  Fabian, can you try it using the latest Rails version from git?.
  Thanks

• You flagged this item as spam.
  

  Enrico Bianco May 16th, 2010 @ 12:42 AM

  not reproducible in the latest master:

  ruby-1.8.7-p249 > foo.number_to_currency(101.00)
   => "$101.00"
  
  ruby-1.9.1-p378 > foo.number_to_currency(101.00)
  => "$101.00"
  
  ruby-1.9.2-head > foo.number_to_currency(101.00)
   => "$101.00"
  

• You flagged this item as spam.
  

  Fabian Schwahn May 16th, 2010 @ 12:42 AM

  ok, I investigated a little further, and the bug only occurs if the default locale is set to :de .
  So, if I set
  

  ---

  config.i18n.default_locale = :de
  

  ---

  in config/application.rb and execute the following in the console:
  

  ---

  foo = ActionView::Base.new
  foo.extend ActionView::Helpers::NumberHelper
  foo.number_to_currency(101.00)
  

  ---

  I am able to reproduce the bug with a fresh app.

  Also happens with edge rails.

• You flagged this item as spam.
  

  Fabian Schwahn May 16th, 2010 @ 01:28 AM

  ok, some more information:
  Apparently, if you set a locale different than :en, the number helpers stop working.
  That is because the options are set as follows (in action_view/helpers/number_helper.rb):
  

          defaults  = I18n.translate(:'number.format', :locale => options[:locale], :default => {})
  
  
  
  
  
  
  

      currency  = I18n.translate(:'number.currency.format', :locale => options[:locale], :default => {})
      defaults  = defaults.merge(currency)
  
      options = options.reverse_merge(defaults)
  
      unit      = options.delete(:unit)
      format    = options.delete(:format)
  
      begin
        value = number_with_precision(number, options.merge(:raise => true))
        format.gsub(/%n/, value).gsub(/%u/, unit).html_safe</code>
  

  So if I change the locale to anything else than the standard, and don't set the number formats up properly in config/locales/foo.yml, the number helpers crash, because unit, format and precision (in number_with_precision) are nil.
  A solution would be to set the :en-locale as default here:
  

  defaults  = I18n.translate(:'number.format', :locale => options[:locale], :default => {})
  

  in the default-hash.
• 

  Santiago Pastorino May 16th, 2010 @ 02:09 AM

  • Milestone cleared.
  • State changed from “new” to “open”
  • Assigned user set to “Santiago Pastorino”

  Reproduced, working on a fix

• 

  Santiago Pastorino May 16th, 2010 @ 08:38 PM

  Patch for master

  • number_helper_bug.patch 3 KB
• 

  Santiago Pastorino May 16th, 2010 @ 10:00 PM

  new patch

  • number_helper_bug.patch 3.3 KB
• 

  José Valim May 16th, 2010 @ 10:04 PM

  Pastorino, this still does not solve the problem. It should be something like this:

  defaults  = default_currency_values.merge(defaults).merge!(currency)
  

• You flagged this item as spam.
  

  Rafael Mendonça França May 17th, 2010 @ 01:02 AM

  +1

  This work fines for me. All tests pass.

• 

  Santiago Pastorino May 17th, 2010 @ 03:45 PM

  The correct patch here

  • number_helper.patch 3.1 KB
• 

  Repository May 17th, 2010 @ 04:40 PM

  • State changed from “open” to “committed”

  (from [c7e6777961239224e28171a46c9768db881c5506]) Added default currency values to NumberHelper and pass them to I18n.translate

  [#4604 state:committed]

  Signed-off-by: José Valim jose.valim@gmail.com
  http://github.com/rails/rails/commit/c7e6777961239224e28171a46c9768...

• 

  Jeremy Kemper October 15th, 2010 @ 11:01 PM

  • Milestone set to “3.0.2”
  • Importance changed from “” to “Low”

  [bulk edit]