2 failures in Action Pack in master on 1.9.2-head

The first failing test is a strange one. I tried recreating what the test is trying to do in a sample app.

I created a Post resource and then the following.

• app/helpers/posts_helper.rb

module PostsHelper
  def render_from_helper
    form_tag('/foo') do
      safe_concat render(:text => '<ul><li>foo</li></ul>')
    end  
  end
end

• app/views/posts/index.html.erb

<%= render :partial => 'test/from_helper' %>

• app/views/test/_from_helper.html.erb

<%= render_from_helper %>

• OUTPUT of localhost:3000/posts

...
<form action="/foo" method="post"><div style="margin:0;padding:0;display:inline"><input name="authenticity_token" type="hidden" value="/IYCV0CzIdNbd6Z03ZnpN2wbgHwGkB4mtlPtr0j3rpU=" /></div><ul><li>foo</li></ul></form>
...

If this is what the test is trying to do then it works perfectly on 1.9.2 (head and preview3). However the render :partial in the test just doesn't render the form(renders the UL list inside it) on 1.9.2. Works fine on 1.8.7.

I tried following the render :partial call, reached upto actionpack/lib/action_view/render/partials.rb but I couldn't find any difference between the path it took on 1.8.7 and 1.9.2 except that it doesn't render the form on 1.9.2 :(

Thanks to Jose's help, actionpack tests now pass on 1.9.2 and 1.8.7. Attached is the patch.

(from [ccb21f20d86ffc17c10cb5e476912157c739dd96]) Convert instance_variables to symbols before excluding internal vars [#4965 2 failures in Action Pack in master on 1.9.2-head state:resolved]

Signed-off-by: José Valim jose.valim@gmail.com
http://github.com/rails/rails/commit/ccb21f20d86ffc17c10cb5e4769121...