ActiveRecord#calculate broken for multiple fields in :group option

+1 for fixing this issue.

+1 for addressing this issue. or being much more explicit in the docs. I would want multiple group by support, achieved via an array as the original post suggests.

+1 for having a way to group by multiple fields.

+1 In the meantime, see my ugly hack: poor_mans_group_by.rb http://pastie.org/471055 coalesce deals with nulls and delimitters are chosen to be unicode values unlikely to be used in your code.

Couldn't we use the returned row-hash (minus count_all) as the key?

+1 for getting this fixed...

Here's another +1

Another +1. This patch would be very useful.

Another +1.

+1

+1

for those looking for temporary support of this, there is a plugin i tracked down from some other references in this thread: http://github.com/patientslikeme/multi_field_group_by

Uploading a patch here in case any of you guys want to verify it.

I verified your patch and made it work against the 3-0-stable branch. I also added one more test case for using sql-functions in the group clause.

+1

I updated the patch to work against master branch.

Hi everyone! I'd really like to push rails to do less SQL parsing. Parsing SQL is a dangerous game.

If we could support this via a list passed to the :group clause (as @gix suggests), would that be OK with everyone?

I agree that is better. The only reason it was done that way was because the documentation when this issue was first opened hinted that the correct usage was to pass in a SQL frag. I updated the patches for master and 2-3-stable such that there is no SQL parsing. They are attached.

Forgot to attach 2-3-stable patch.

@Alex excellent, thank you. I'll apply and push after verifying everything. Thanks for the patches!

Great news! Thank you.

Are you sure this bug is fixed ?

I've tested with AR 3.0.3+your patch and AR 3.0.4.rc built with the Git repository, the SQL query is correct but not the response of the method.

code:

pp SavedForm.count(:group => 'agent_id, code_dispo')

result:

DEBUG -- :   SQL (1.4ms)  SELECT COUNT(*) AS count_all, agent_id, code_dispo AS agent_id_code_dispo FROM saved_forms GROUP BY agent_id, code_dispo
{"bte_vocale"=>3, "CB"=>1, "nc"=>1, "pasok"=>4, "wln"=>2, "ok"=>3}

# gem list

*** LOCAL GEMS ***

activemodel (3.0.4.rc)
activerecord (3.0.4.rc)
activesupport (3.0.4.rc)

Alex, I've just tested with your patch of November 13th, 2010 @ 10:52 PM, it runs correctly.

Only your latest patch has a problem.

If I can help, don't hesitate to contact me.

Yours.

The usage should be pp SavedForm.count(:group => [ 'agent_id', 'code_dispo']). The reason we do this is to avoid SQL parsing. This is not documented anywhere yet, so eventually we should be adding this to the rails doc.

I can confirm this isn't fixed. And +1 for getting it fixed.

Also, I'll be taking another look at it this weekend.

I confirm this bug isn't fixed in 3.0.7.

I don't understand why the patch isn't applied on the source code since 6 months, what's the problem ?