#5724 Subclasses of HashWithIndifferentAccess dup the wrong class - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#5724 ✓resolved

Subclasses of HashWithIndifferentAccess dup the wrong class

Reported by Steve Richert | September 28th, 2010 @ 03:56 PM

There are two instances of HashWithIndifferentAccess being named explicitly in its own class. No bug there, but if a new class is created that inherits from HashWithIndifferentAccess, the new_from_hash_copying_default class method and the dup instance method incorrectly return an instance of HashWithIndifferentAccess rather than the newly-created class.

class FooHash < HashWithIndifferentAccess
end

foo = FooHash.new # => {}
foo.class         # => FooHash
bar = foo.dup     # => {}
bar.class         # => HashWithIndifferentAccess

Comments and changes to this ticket

You flagged this item as spam.
Steve Richert September 28th, 2010 @ 04:00 PM
Patched, with no tests as it seems pretty straightforward.
- hash_with_indifferent_access_dup_inheritance.diff 1.2 KB
You flagged this item as spam.
laserlemon September 29th, 2010 @ 05:20 PM
- Tag changed from “duplicate, hashwithindifferentaccess” to “hashwithindifferentaccess”
David Trasbo October 10th, 2010 @ 04:51 PM
- State changed from “new” to “incomplete”
- Importance changed from “” to “Low”
+1, but:

Rule no. 1: Always add tests. This is no exception. :)

And I'd replace self.class.new with just class.new.
You flagged this item as spam.
laserlemon October 11th, 2010 @ 12:10 PM
Here's a new patch including tests. I also discovered that HashWithIndifferentAccess duplication doesn't preserve a default value so I resolved that issue as well. Thank you!
- hash_with_indifferent_access_duplication.diff 4.2 KB
You flagged this item as spam.
laserlemon October 11th, 2010 @ 12:14 PM
I should also mention that class.new isn't valid Ruby, so I stuck with self.class.new.
David Trasbo October 11th, 2010 @ 06:57 PM
Ah, ok. Silly me, didn't think about that!

Anyways: +1

Patch applies cleanly and tests pass. Please do unify all the commits in the patch, though.
You flagged this item as spam.
laserlemon October 12th, 2010 @ 02:25 AM
Thanks again for the advice. Here's a new, single-commit diff with a message resolving the ticket.
- hash_with_indifferent_access_duplication.diff 2.9 KB
You flagged this item as spam.
ara.t.howard October 12th, 2010 @ 03:39 AM
some people might be interested in this:

http://github.com/ahoward/map

i've fought long and hard with HashWithIndiffentAccess and finally broke down and merged it with OrderedHash - Map is the result. it fixes the issue in this thread too.
Ryan Bigg October 19th, 2010 @ 08:26 AM
- Tag cleared.
Automatic cleanup of spam.
Repository November 7th, 2010 @ 12:21 PM
- State changed from “incomplete” to “resolved”
(from [02039e9752bcb214c2ad85859ecf47dcbb892225]) Ensure that HashWithIndifferentAccess duplication preserves class (for sublclasses) and default value [#5724 state:resolved]

Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/02039e9752bcb214c2ad85859ecf4...