This project is archived and is in readonly mode.
Make ActiveSupport::Configurable work with Modules
Reported by Josep M. Bach | February 28th, 2011 @ 01:36 PM
Currently ActiveSupport::Configurable mixin can
only be included in Classes (because it calls their
superclass method). By adding an additional check
(responds_to?(:superclass)), the mixin can be included
in regular Modules as well. Patch with tests included.
Comments and changes to this ticket
-
Jeff Kreeftmeijer February 28th, 2011 @ 02:35 PM
- State changed from “new” to “verified”
- Assigned user set to “Santiago Pastorino”
- Importance changed from “” to “Low”
Verified. The added test fails (raising a
NameErrorbecausesuperclassis undefined) without the patch. Thanks Josep! :) -
Repository February 28th, 2011 @ 03:44 PM
- State changed from “verified” to “committed”
(from [f42562f97bb791a7662fce0106a93eec211b2803]) Make ActiveSupport::Configurable work with modules
[#6486 state:committed]
Signed-off-by: Santiago Pastorino santiago@wyeworks.com
https://github.com/rails/rails/commit/f42562f97bb791a7662fce0106a93...
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
Jeff Kreeftmeijer
Jeremy Kemper
Manfred Stienstra
Piotr Sarnacki
Attachments
Referenced by
-
6486
Make ActiveSupport::Configurable work with Modules
[#6486 state:committed]