Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Dan Croak's latest activity

Sunday, August 09 2009
3023 Removed unused routing method was updated in Ruby on Rails
  • Dan Croak
    • Assigned user set to Pratik
    by Dan Croak at 5:56 PM
  • Dan Croak
    Dan Croak commented at 5:56 PM

    +1 verified Gabe's patch applies to 2-3-stable.

    I've attached a patch that deprecates instead of removes. Suggests route_for().

3022 [PATCH] ActiveSupport tests fail when run from a directory with a space in it... was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 5:44 PM

    +1 verified issue exists in 2-3-stable.

    I've attached a patch that applies cleanly in 2-3-stable.

3015 use backtrace_cleaners when using Deprecation#warn was updated in Ruby on Rails
  • Dan Croak
    • Assigned user set to Pratik
    by Dan Croak at 5:32 PM
  • Dan Croak
    Dan Croak commented at 5:18 PM

    Screwed around a bit with mocking the Rails.cleaner. Diff:

    http://gist.github.com/164808

    But getting an error:

    test_assert_deprecation_backtrace_is_cleaned(Dep...

  • Dan Croak
    Dan Croak commented at 4:43 PM

    I've attached a patch that is a test to make sure the "called from #{method} at #{file}:#{line_number}" shows in the deprecation warning, but it passes without ...

  • Dan Croak
    Dan Croak commented at 4:06 PM

    +1 verified 2-3-stable patch applies cleanly and produces a nice deprecation warning with file and line number:

    DEPRECATION WARNING: formatted_beers_url() has b...

2161 Loosing field contents when positioned after file upload was updated in Ruby on Rails
  • Dan Croak
    • Tag changed from bug, file, upload to bug, bugmash, file, upload
    by Dan Croak at 4:47 PM

    -1 not reproducible

2151 routing not recognizing requirements for :format was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 12:05 AM

    I couldn't get Mike's patch to apply on 2-3-stable so I've attached a patch with his test (slightly formatted to fit in my text editor).

    I couldn't figure out w...

Saturday, August 08 2009
1908 Schema dumper ignores custom id column even when :id => false was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 11:56 PM

    +1 verified 2-3-stable patch applies clean and tests run green. Implementation looks good to me.