Dan Croak
web app developer, person · Not a member
Dan Croak's latest activity
Sunday, August 09 2009
-
-
Dan Croak commented at 5:56 PM+1 verified Gabe's patch applies to 2-3-stable.
I've attached a patch that deprecates instead of removes. Suggests route_for().
-
Dan Croak commented at 5:44 PM+1 verified issue exists in 2-3-stable.
I've attached a patch that applies cleanly in 2-3-stable.
-
-
Dan Croak commented at 5:18 PMScrewed around a bit with mocking the Rails.cleaner. Diff:
But getting an error:
test_assert_deprecation_backtrace_is_cleaned(Dep...
-
Dan Croak commented at 4:43 PMI've attached a patch that is a test to make sure the "called from #{method} at #{file}:#{line_number}" shows in the deprecation warning, but it passes without ...
-
Dan Croak commented at 4:06 PM+1 verified 2-3-stable patch applies cleanly and produces a nice deprecation warning with file and line number:
DEPRECATION WARNING: formatted_beers_url() has b...
-
- Tag changed from bug, file, upload to bug, bugmash, file, upload
-1 not reproducible
-
Dan Croak commented at 12:05 AMI couldn't get Mike's patch to apply on 2-3-stable so I've attached a patch with his test (slightly formatted to fit in my text editor).
I couldn't figure out w...
Saturday, August 08 2009
-
Dan Croak commented at 11:56 PM+1 verified 2-3-stable patch applies clean and tests run green. Implementation looks good to me.