Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Dan Croak

Dan Croak

web app developer, person · Not a member

Dan Croak's latest activity

Monday, August 10 2009
1183 Switch active_model to use I18n.translate method instead was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 4:04 AM

    +1 verified patch applies if the second commit regarding I18n is deleted.

    I believe the second commit is unnecessary because Edge Rails now elegantly handles #t...
2723 to_xml generates invalid xml with namespaced ActiveRecord was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 3:30 AM

    +1 verified Josh's 2723-invalid_namespaced_xml-backport.patch applies cleanly and runs green.
2765 after_create callback not working as it should was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 3:20 AM

    -1 I added the after_create callback and test barurio suggested on August 4th, 2009 @ 03:42 AM and tests passed.

    I don't think this is a bug.
2503 validates_uniqueness_of is horribly inefficient in mysql was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 3:01 AM

    -1 on changing case_insensitive to non-boolean.

    My understanding is that the problem here is the BINARY conversion for MySQL, correct? When running a 2.3.3 app,...
1472 ActiveResource errors.from_xml Can't handle symboled attribute keys because o... was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 2:41 AM

    Pratik mentioned in IRC that he'd like to see a test for from_xml added to this patch before it is committed. I started to look into it but am on another comput...
2934 association_collection#create acts as association_collection#create! was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 2:33 AM

    I've attached a patch that works for 2-3-stable. It was modified from railsbob's 2934_fixed.diff patch for master. I don't think it is possible to have a single...
  • Dan Croak
    Dan Croak commented at 2:18 AM

    verified 2934_fixed.diff does not apply cleanly to 2-3-stable.
2510 url_for ignores routing priority was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 2:12 AM

    +1 verified Gabe's patch applies to 2-3-stable and actionpack rake test runs green.
Sunday, August 09 2009
2306 AssociationCollection's destroy method is not compatible with old version was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 6:59 PM

    +1 verified Josh's patch applies to 2-3-stable and tests run green.

    I have attached a patch that alters his implementation to check ActiveRecord::Base instead o...
2353 helper caching issue was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 6:00 PM

    -1 should use date conversions