Dan Croak
web app developer, person · Not a member
Dan Croak's latest activity
Saturday, August 08 2009
-
Dan Croak commented at 10:49 PM+1 verified patch applies cleanly. Looks like the right error message now.
-
Dan Croak commented at 10:34 PMWhat tests should be run to verify this patch?
The fix_sessions patch applies cleanly in 2-3-stable and rake test runs green for railties.
However, I'm not sure...
-
Dan Croak commented at 10:18 PM+1 verified in 2-3-stable.
Patch applies cleanly. activeresource rake test runs green.
-
Dan Croak commented at 10:10 PM+1 verified
tag_options.diff and 0001-Added-tests-for-using-an-Array-in-tag_options-and-re.patch apply cleanly
and rake test_action_pack runs green on 2-3-stabl...
-
- Assigned user set to Pratik
+1 to stevestmartion's truncate_patch_2-3-stable.diff
It applies cleanly, rake test_action_pack runs green. Even covers 1.9 multibyte characters! Nice job.
-
Dan Croak commented at 9:03 PMJosh is working on changing the output to include file and line number.
-
- Assigned user set to Pratik
Attached a passing 2-3-stable patch that is a test ensuring redirect_to uses the given protocol.
-
Dan Croak commented at 8:12 PM-1
While I agree on not producing helpers, I write my own generators to override things like this.
I say: "use a custom generator or wait until Rails 3.0." This...