Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Dan Croak's latest activity

Saturday, August 08 2009
2273 ActiveSupport::JSON.decode dies on double escaped string was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 11:02 PM

    uhhh... hardbap told me to say this is "verified"

  • Dan Croak
    Dan Croak commented at 11:00 PM

    Should be marked as "resolved, duplicate". Fix merged in by Yehuda in [#2831].

3012 test tasks fail when db/schema.rb doesn't exist was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 10:49 PM

    +1 verified patch applies cleanly. Looks like the right error message now.

2745 db:sessions:clear to respect legacy table names was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 10:34 PM

    What tests should be run to verify this patch?

    The fix_sessions patch applies cleanly in 2-3-stable and rake test runs green for railties.

    However, I'm not sure...

1472 ActiveResource errors.from_xml Can't handle symboled attribute keys because o... was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 10:18 PM

    +1 verified in 2-3-stable.

    Patch applies cleanly. activeresource rake test runs green.

1741 tag_options should properly handle arrays was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 10:10 PM

    +1 verified

    tag_options.diff and 0001-Added-tests-for-using-an-Array-in-tag_options-and-re.patch apply cleanly

    and rake test_action_pack runs green on 2-3-stabl...

2899 [PATCH] Rails 2.1.0 ActionView::Helpers::TextHelper#truncate was updated in Ruby on Rails
  • Dan Croak
    • Assigned user set to Pratik
    by Dan Croak at 9:16 PM

    +1 to stevestmartion's truncate_patch_2-3-stable.diff

    It applies cleanly, rake test_action_pack runs green. Even covers 1.9 multibyte characters! Nice job.

2932 Deprecation warning for assert_redirected_to doesn't tell you where the offen... was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 9:03 PM

    Josh is working on changing the output to include file and line number.

2886 Using redirect_to with params merge of protocol doesn't take effect was updated in Ruby on Rails
  • Dan Croak
    • Assigned user set to Pratik
    by Dan Croak at 8:43 PM

    Attached a passing 2-3-stable patch that is a test ensuring redirect_to uses the given protocol.

3011 [Patch] --skip-helper for controller tests was updated in Ruby on Rails
  • Dan Croak
    Dan Croak commented at 8:12 PM

    -1

    While I agree on not producing helpers, I write my own generators to override things like this.

    I say: "use a custom generator or wait until Rails 3.0." This...