This project is archived and is in readonly mode.
[Patch] --skip-helper for controller tests
patch attached
Generally, I like to make my helpers domain specific and I don't always have a need for them when I generate my controllers. It ultimately results in a lot of cruft in my app/helpers directory
This --skip-helper will omit the helper and the helper test from the files that are generated.
Arguably, I'd like to make this the default, but I realize that might be a little dramatic.
-
skip_helper.diff
5.02 KB
-
José ValimAlready working on Rails 3.0. You can try to convince some from core to get them applied on Rails 2.3. :)
-
Josh Nichols+1, because if I usually immediately delete the generated helper.
-
Dan Croak-1
While I agree on not producing helpers, I write my own generators to override things like this.
I say: "use a custom generator or wait until Rails 3.0." This doesn't need to be in Rails 2.3.
-
Josh Nichols
Verified the patch works as expected.
-
Steve St. Martin-1 I usually delete helpers as well, however I think this feature can wait till 3.0 as this is a change in behavior and not really a bug (is there a possibility this might break anyones custom generators?).
-
AmundS+1 helpers usually sit empty, more often than not I don't need them.
-
Dmitry Ratnikov+1 since helpers are usually empty and in the event that you do want to generate them, should have also generated a corresponding helper unit test. That is currently not done anyway.
-
Rizwan Rezaverified
+1 patch applies cleanly on 2-3-stable.
-
Derander
+1 verified on 2-3-stable.
This is a simple change that won't break anything to make some people's lives better on 2.3.
-
Elad Meidar+1 Verified on 2-3-stable, tested manually as well.
good to know generators are getting smarter on 3.0
-
Jeremy Kemper- Tag changed from 2.3.x, bugmash to 2.3.x
- State changed from new to wontfix
I'd rather not pile on more options. How often are you even going to remember to provide it? Deleting the file is simple enough.