Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Sam Pohlenz

Sam Pohlenz

Not a member

Sam Pohlenz's latest activity

Thursday, May 20 2010
4657 Remove unnecessary meta programming from polymorphic_routes.rb was updated in Ruby on Rails
  • Sam Pohlenz
    Sam Pohlenz commented at 7:44 AM

    +1 for this patch. The expanded methods are much clearer IMO.
Tuesday, May 18 2010
4637 [PATCH] Fix JSON serialization of ActiveModel::Errors was created in Ruby on Rails
  • Sam Pohlenz
    Sam Pohlenz created the ticket at 8:48 AM

    JSON encoding an ActiveModel::Errors object with :only option currently breaks:

    >> ActiveSupport::JSON.encode(ActiveModel::Errors.new(nil), :only => :attribute...
Friday, April 02 2010
4308 [PATCH] Restore changed_attributes method in ActiveModel::Dirty was updated in Ruby on Rails
  • Sam Pohlenz
    Sam Pohlenz commented at 12:52 AM

    Adding a one-line method (and removing initialize) is simpler than requiring that the including class always call super within its initialize method. Why push t...
Thursday, April 01 2010
4308 [PATCH] Restore changed_attributes method in ActiveModel::Dirty was created in Ruby on Rails
  • Sam Pohlenz
    Sam Pohlenz created the ticket at 12:01 PM

    It seems that this commit removed the changed_attributes method from ActiveModel::Dirty, which lazily loaded the @changed_attributes ivar.

    This then required ...
Thursday, January 21 2010
3230 Zero-arity conditional validation procs broken by AS::NewCallbacks was updated in Ruby on Rails
  • Sam Pohlenz
    Sam Pohlenz commented at 9:28 AM

    This appears to now be fixed. Thanks.
Saturday, January 16 2010
3703 [PATCH] Allow resource(s) to specify a custom controller was created in Ruby on Rails
  • Sam Pohlenz
    Sam Pohlenz created the ticket at 12:43 AM

    This patch allows resource and resources declarations to specify a custom controller name. This functionality had been suggested in the routing tests (resources...
Sunday, December 27 2009
3623 [PATCH] Make plugins responsible for loading their own rake tasks was created in Ruby on Rails
  • Sam Pohlenz
    Sam Pohlenz created the ticket at 10:29 PM

    This patch offloads the responsibility of loading plugin rake tasks to the Plugin objects themselves. This allows subclasses of Rails::Plugin to override the lo...
3621 [PATCH] Application object should instantiate non-vendored plugins was created in Ruby on Rails
  • Sam Pohlenz
    Sam Pohlenz created the ticket at 1:11 AM

    To ensure that plugin initializers are run with the correct binding, non-vendored plugins should be instantiated by the Rails::Application object (Plugin::Vendo...
Monday, September 21 2009
3230 Zero-arity conditional validation procs broken by AS::NewCallbacks was updated in Ruby on Rails
  • Sam Pohlenz
    Sam Pohlenz commented at 2:01 AM

    After some more digging, it seems the problem is due to a variation between Ruby 1.8 and 1.9.

    In 1.8.6 and 1.8.7, Proc.new {}.arity == -1, whereas in 1.9, Proc....
Friday, September 18 2009
3230 Zero-arity conditional validation procs broken by AS::NewCallbacks was created in Ruby on Rails
  • Sam Pohlenz
    Sam Pohlenz created the ticket at 5:59 AM

    Using a zero-arity proc/lambda as an :if or :unless option for validations, breaks with the new callback code. This potentially affects a lot of legacy code.

    Co...