This project is archived and is in readonly mode.
Remove unnecessary meta programming from polymorphic_routes.rb
-
Jury
- Tag set to patch
-
Anil Wadghule
I think comments for the meta programming code are just fine. Those clearly show what code is doing.
-
Damien MATHIEU
I also think the comments makes it explicit enough. There's no need to do code repetition for this here.
-
Sam Pohlenz
+1 for this patch. The expanded methods are much clearer IMO.
-
Keith Tom
+1 also. It's cleaner and I don't see an advantage to keeping the meta programming; maybe if it was for more than just 2 methods...
-
xds2000
+1,with ruby style,this is cleaner and easy maintaining code.
-
James B. Byrne
I have no idea what Tag cleared means, but I certainly never intended to write more than +1.
-
Josh Nesbitt
+1, Much cleaner considering the nature of the methods.
-
Rizwan Reza
- No changes were found…
-
Evgeniy Dolzhenko
+1 (same LOC count with direct solution - no win from metaprogramming)
-
Santiago Pastorino
- State changed from new to open
- Importance changed from to Medium
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.
Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.
-
Santiago Pastorino
- State changed from open to stale
