Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Dan Pickett

Dan Pickett

Principal · Member of 1 project: Ruby on Rails

Dan Pickett's latest activity

Wednesday, October 28 2009
1167 has_one :through using belongs_to produces incorrect SQL was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 10:08 PM

    I've attached a patch that verifies this is fixed in 2-3-stable with a concrete test case. Please review and advise
Saturday, September 26 2009
3106 [PATCH] distance_of_time_in_words inaccurate for 'about 1 year ago' was updated in Ruby on Rails
  • Dan Pickett
    • Tag changed from action_view, bugmash, date_helper, patch to action_view, bugmash, bugmash-review, date_helper, patch
    by Dan Pickett at 5:56 PM
  • Dan Pickett
    Dan Pickett commented at 5:53 PM

    +1 verified
  • Dan Pickett
    Dan Pickett commented at 5:38 PM

    John Trupiano,

    I think you should create another ticket for the introduction of the "almost" identifier. I think that's more accurate than "over" given a certai...
3141 Template is missing error could be more helpful was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 5:31 PM

    I'm not sure this approach will work - I think for the message to be effective, we want to know what content type / format the user is requesting.
Sunday, August 09 2009
2306 AssociationCollection's destroy method is not compatible with old version was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 6:48 PM

    +1 verified

    latest patch applies cleanly to master and tests behavior adequately
2943 drop_table to support temporary option like create_table was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 12:11 AM

    verified that this patch applies cleanly to master

    -1 on the implementation and feature, though - this sounds like it belongs in an adapter specific plugin or g...
2489 Enumerable#sum should not rely on size was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 12:04 AM

    +1 verified

    I like Jose's optimization idea for range as well.
Saturday, August 08 2009
2379 [PATCH] Make path to tmp directory configurable was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 11:52 PM

    +1 for the feature

    verified that the patch applies cleanly to master

    There currently isn't any tests associated with this patch - would it be possible to includ...
2370 [PATCH] Ability to set SSL options on ActiveResource connections was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 11:46 PM

    +1 for the feature

    could not get this to apply cleanly to 2-3-stable or master

    I'm not sure this belongs in 2.x, though. Maybe edge? I wonder too if we could pu...