Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Dan Pickett

Dan Pickett

Principal · Member of 1 project: Ruby on Rails

Dan Pickett's latest activity

Saturday, August 08 2009
2431 deprecate fails on methods ending with equal sign was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 11:40 PM

    sorry - Josevalim corrected me symbols with = at the end are valid > 1.8.6
  • Dan Pickett
    Dan Pickett commented at 11:31 PM

    verified

    -1 however - a symbol cannot end in equal sign - the deprecate call should really be proper syntax -

    deprecate "bar="
2627 has_many :dependent => :delete_all throws exception on models in modules was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 11:21 PM

    +1 verified

    this applies cleanly to master with a few whitespace warnings

    test suite passes

    note that it does add a few models
1331 Allow arbitrary named_scope instances to be merged was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 11:07 PM

    +1 for the feature - I've definitely run into use cases where I've wanted this, but I'm not sure I agree with the implementation

    Also, I could not merge this in...
1639 Adds an :on option to ActiveRecord observers was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 10:44 PM

    +1 this is nice syntax

    having trouble applying the patch - will try to apply to master and modify as necessary
1828 ActiveResource breaks when encounters <object> tag in XML was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 10:38 PM

    verified

    -1 on this - I think accommodating the object element will lead to lots of special handling

    From an XML perspective as well, it's not very descriptive ...
1975 Allow to register javascript/stylesheet_expansions to existing symbols was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 10:31 PM

    verified that this applies cleanly to 2-3-stable

    -1 on this, though imo - this could get really confusing and unwieldy if you keep appending to the same expansi...
2049 to_xml nil => true attribute should not appear when I skip types was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 10:24 PM

    -1 verified that this occurs in 2-3-stable

    :skip_types is to remove data types while nil="true" indicates that the value is nil. The desired behavior does not m...
1599 Rake test task looks at wrong database was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 10:10 PM

    -1 on this as well - I think this is something that we might want to address in 3, but I don't identify it as critical to 2.x - in the use case of CI, I just cr...
2048 undefined method `quoted_table_name' with model called "schema" was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 9:57 PM

    not reproducible

    I was able to create a new rails app with a schema model and a user model - upon creating and destroying a user I did not get any errors