Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Dan Pickett

Dan Pickett

Principal · Member of 1 project: Ruby on Rails

Dan Pickett's latest activity

Saturday, August 08 2009
1472 ActiveResource errors.from_xml Can't handle symboled attribute keys because o... was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 9:30 PM

    patch attached validated +1

    I took a swing at a patch for this to stringify the keys. pretty simple.
2765 after_create callback not working as it should was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 8:36 PM

    +1 verified that this occurs and that I'm not able to reproduce in the active record test suite.
1231 polymorphic_url gives incorrect url for :has_one nested resource was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 8:25 PM

    -1 sounds like a lot of overhead for something that can be handled by a symbol currently
2886 Using redirect_to with params merge of protocol doesn't take effect was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 8:16 PM

    Not reproducible - verified Edd Morgan's tests pass on 2-3-stable
2893 Rails 2.3.x - "render :text => proc" - problems with output buffer was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 8:09 PM

    +1 and I verified Nick's patch applies cleanly to master - patch applies and suite passes
2269 Enumerable#sum not called on some association collections was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 8:01 PM

    -1 - I disagree that this is a bug -

    this is by design to me - the finder should always return an array. conditions should be supplied in the sum call.
2086 Primary key on HABTM join table now raises an exception was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 7:57 PM

    +1 for the feature but the patch did not apply cleanly to 2-3-stable - I also attempted to apply it to master but no joy.

    I was recently bitten by this last wee...
3006 Patch to fix broken HTTP Digest Authentication was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 7:44 PM

    Verified

    +1 applied to 2-3 stable without issue
2425 [PATCH] Add methods on active record to denote whether any associated objects... was updated in Ruby on Rails
  • Dan Pickett
    Dan Pickett commented at 7:27 PM

    -1 on the implementation

    I agree with Nick on this as well.

    note that #49 was similar and denied - although this has more to do with verifying that the collecti...
3011 [Patch] --skip-helper for controller tests was created in Ruby on Rails
  • Dan Pickett
    Dan Pickett created the ticket at 7:11 PM

    patch attached

    Generally, I like to make my helpers domain specific and I don't always have a need for them when I generate my controllers. It ultimately result...