Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Elad Meidar

Elad Meidar

Not a member

Elad Meidar's latest activity

Sunday, September 27 2009
3207 [PATCH] layouts with absolute path not found if path does not contain "layouts" was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 9:41 PM

    +1 verified and applied cleanly on 2-3-stable. i think this is unreproducible in master, there seem to be a different implementation that amends the layouts/ pr...
3280 Prefer tap over returning in ActionMailer was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 9:32 PM

    +1 agreed, 1 patch per major lib should cover it.
  • Elad Meidar
    Elad Meidar commented at 9:06 PM

    There's also lib/active_support/core_ext/enumerable.rb#78 and lib/active_support/core_ext/range/blockless_step.rb#15
1828 ActiveResource breaks when encounters <object> tag in XML was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 9:29 PM

    @Maxim: correct, but stilll Game.new.objective is a much more clear / safe phrase to use.
1333 Partial indices using add_index in DB migrations was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 9:07 PM

    @Jason: as far as i can see (Google, that is), mysql does not support "where" clauses in CREATE INDEX syntax.. could it be that it's just a postgres's feature?
3263 Failing functional test of a named route was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 8:19 PM

    No it's not.... i tried a different action name and it still failed... possibly this has something to do with the catch-all route that may be required.
  • Elad Meidar
    Elad Meidar commented at 8:10 PM

    +1 verified.

    it might have something to do with the use of accept as a method name? maybe get :accept is confusing for some reason...
3192 should be able to truncate a multibyte string to a max # of bytes was updated in Ruby on Rails
  • Elad Meidar
    • Tag changed from bugmash to bugmash, multibyte
    by Elad Meidar at 7:52 PM

    since it's a bit staling i've attached a patch that applies on both master and 2-3-stable
3239 add method to check if association is eager loaded was updated in Ruby on Rails
  • Elad Meidar
    • Tag changed from active_record, association, associations, associations_preload, bugmash to active_record, association, associations, associations_preload, bugmash-review
    by Elad Meidar at 7:34 PM
  • Elad Meidar
    Elad Meidar commented at 7:31 PM

    +1 might come useful around tests, more than in a production environment. i've attached patches for 2-3-stable and master.