Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Elad Meidar's latest activity

Sunday, September 27 2009
3200 [PATCH] For Rails 2.3 stable. Add layout override option to ActionMailer was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 7:15 PM

    +1 verified on Master and 2-3-stable, -1 on patch.... i'd rather to have a new test as Jesse suggested, rather than replacing the existing one.

3188 [ActiveRecord] create(:association_id => @object.id) vs create(:association_i... was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 7:09 PM

    argh, markdown fails. :)

  • Elad Meidar
    Elad Meidar commented at 7:09 PM

    i Dug into it, and came up with type_cast as the issue, i added a special case for type casting AR:Base decedent instances as values (defaults to primary key re...

  • Elad Meidar
    Elad Meidar commented at 4:50 PM

    +1 verified on 2-3-stable and master.

    iv'e attached a patch with a failing test (created on 2-3-stable, applies on master too).

1828 ActiveResource breaks when encounters <object> tag in XML was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:33 PM

    +1 Verified, but i am too not very fond of the hard-code solution. I agree with Dan and Elomar, that Object should be left alone and a more descriptive name sho...

3246 [PATCH] error_message_on does not display error message when form builder is ... was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 7:48 AM

    +1 verified and patch applies on both 2-3-stable and master. maybe @object_name.to_s might also give you the option to use f.error_messages_for(:author_name)

3129 [patch] better cleaning of gem directories was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 7:42 AM

    +1 verified on 2-3-stable and patch applies cleanly, tests pass a well.

3005 :counter_cache not updated if polymorphic => true when assigning association was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 7:18 AM

    +1, verified on 2-3-stable and master.

    I was going through the flow of this process and i came up with this

    1. There is not test that checks counter_cache changes...
2553 ActionView::TemplateHandlers::ERB.erb_trim_mode= broken was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 6:27 AM

    +1 verified on 2-3-stable indeed, but not on master... Obviously Dan is right, the freeze occurs on load, which is before the initializers are run... hence the ...

3205 [PATCH] Fix Hash#from_xml with empty hash (using REXML backend) was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 6:17 AM

    +1 verified on master and 2-3-stable Master patch applies cleanly and tests pass.
    i've attached a patch for 2-3-stable.