Elad Meidar
Not a member
Elad Meidar's latest activity
Sunday, September 27 2009
-
Elad Meidar commented at 7:15 PM+1 verified on Master and 2-3-stable, -1 on patch.... i'd rather to have a new test as Jesse suggested, rather than replacing the existing one.
-
-
Elad Meidar commented at 7:09 PMi Dug into it, and came up with
type_castas the issue, i added a special case for type casting AR:Base decedent instances as values (defaults to primary key re... -
Elad Meidar commented at 4:50 PM+1 verified on 2-3-stable and master.
iv'e attached a patch with a failing test (created on 2-3-stable, applies on master too).
-
Elad Meidar commented at 4:33 PM+1 Verified, but i am too not very fond of the hard-code solution. I agree with Dan and Elomar, that Object should be left alone and a more descriptive name sho...
-
Elad Meidar commented at 7:48 AM+1 verified and patch applies on both 2-3-stable and master. maybe
@object_name.to_smight also give you the option to usef.error_messages_for(:author_name)
-
Elad Meidar commented at 7:42 AM+1 verified on 2-3-stable and patch applies cleanly, tests pass a well.
-
Elad Meidar commented at 7:18 AM+1, verified on 2-3-stable and master.
I was going through the flow of this process and i came up with this
- There is not test that checks counter_cache changes...
-
Elad Meidar commented at 6:27 AM+1 verified on 2-3-stable indeed, but not on master... Obviously Dan is right, the
freezeoccurs on load, which is before the initializers are run... hence the ...
-
Elad Meidar commented at 6:17 AM+1 verified on master and 2-3-stable Master patch applies cleanly and tests pass.
i've attached a patch for 2-3-stable.