Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Elad Meidar's latest activity

Sunday, September 27 2009
1285 Reduce queries in uniqueness validation was updated in Ruby on Rails
  • Elad Meidar
    • Tag changed from activerecord, bugmash, database, models, performance, validations to activerecord, bugmash, bugmash-review, database, models, performance, validations
    by Elad Meidar at 5:47 AM

    +1 verified the overhead query, tests pass on 2-3-stable and tests pass. Master on the other hand, fails. i've attached a patch for master. (sorry about the cre...

3138 [PATCH] ActiveSupport::Memoizable - flush_cache fails for methods ending in ? was updated in Ruby on Rails
  • Elad Meidar
    • Tag changed from activesupport, bugmash, memoization, patch to activesupport, bugmash, bugmash-review, memoization, patch
    by Elad Meidar at 4:54 AM

    +1 verified on master and 2-3-stable, patch applies cleanly.

    As discussed on #railbridge some further tests for methods that end with ! as well could be nice, a...

1948 Transaction block sets model ID to non-existent row was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:48 AM

    +1 verified Mysql and sqlite 3 Sounds like some kind of a GC is required when rescuing within a transaction. i traced it up until rollback_active_record_state! ...

2998 named_scope ignores :include option was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:17 AM

    +1 verified on 2-3-stable and Master, patch however, applies cleanly only on 2-3-stable.
    i've attached a patch for master, (credits are mine, i have no idea how...

3274 When an ActiveRecord has a column named 'field', bad behavior happens was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:09 AM

    +1 verified and applies cleanly on Master, tests pass as well... also, this may probably lead to also closing down #1742

1742 [PATCH] serialize fails when :null => false was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 4:01 AM

    +1 on Joe's comment in here as well, once changing the name of the field to something else, issue vanished. On the other hand, i was unable to find any appearan...

2989 Setting the id of a belongs_to object does not update the reference to the ob... was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 3:43 AM

    Thanks, but i think there must be a better way to do it (i use eval for god sake... :) ) and further more considerations are required as for the extra queries.

  • Elad Meidar
    Elad Meidar commented at 3:03 AM

    +1 verified the test fails on 2-3-stable, iv'e attached a patch that reloads all the associations that rely on a specific column, once it's changed. THERE ARE F...

3199 `starts/ends_with?` implementations incompatible with that of ruby 1.8.7 was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 3:41 AM

    +1 verified the bug and the 2-3-stable patch applies cleanly, i've attached a patch for master, note that i didn't credit Mislav.. but only because i have no id...

1367 [PATCH] Add a NullStore to ActiveSupport::Cache was updated in Ruby on Rails
  • Elad Meidar
    Elad Meidar commented at 3:31 AM

    +1 verified and nailed :) Looks like it's a well respected behavior, latest patch applies cleanly on latest master.