Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

John Pignata's latest activity

Saturday, September 26 2009
3088 [PATCH] Make has_one with :conditions hash scope build or creation of object ... was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 3:11 AM

    +1 on the feature - this makes a lot of sense to also be a part of has_one associations.

    -1 on the patch as I couldn't get it to cleanly apply to 2-3-stable. As...

Thursday, September 24 2009
2707 dbconsole support password passing through /dev/fd/ was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 2:13 PM

    -1 This is a very involved change for a small security gain. It would probably be best to inform users via the --help msg that using -p could have security impl...

Friday, September 18 2009
3106 [PATCH] distance_of_time_in_words inaccurate for 'about 1 year ago' was updated in Ruby on Rails
  • John Pignata
    • Tag changed from action_view, date_helper to action_view, date_helper, patch
    • Title changed from distance_of_time_in_words inaccurate for 'about 1 year ago' to [PATCH] distance_of_time_in_words inaccurate for 'about 1 year ago'
    by John Pignata at 4:14 AM
3138 [PATCH] ActiveSupport::Memoizable - flush_cache fails for methods ending in ? was updated in Ruby on Rails
  • John Pignata
    • Tag changed from activesupport, memoization to activesupport, memoization, patch
    • Title changed from ActiveSupport::Memoizable - flush_cache fails for methods ending in ? to [PATCH] ActiveSupport::Memoizable - flush_cache fails for methods ending in ?
    by John Pignata at 4:12 AM
3229 Typo fix was updated in Ruby on Rails
Wednesday, September 16 2009
3219 Nokogiri XmlMini backend doesn't properly parse cdata elements was created in Ruby on Rails
  • John Pignata
    John Pignata created the ticket at 7:25 PM

    In a production project I have I'm using Hash#from_xml to parse a bunch of XML from a foreign CMS. I found that changing the backend to Nokogiri gives me an ove...

Friday, September 04 2009
3138 ActiveSupport::Memoizable - flush_cache fails for methods ending in ? was updated in Ruby on Rails
  • John Pignata
    • Tag changed from 3, activesupport, memoization to activesupport, memoization
    by John Pignata at 10:30 PM
  • John Pignata
    • Tag set to 3, activesupport, memoization
    by John Pignata at 10:30 PM

    Added a quick fix and a test for this case.

3106 distance_of_time_in_words inaccurate for 'about 1 year ago' was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 5:50 PM

    I agree with this feature request in spirit as small and worthwhile, but it certainly requires discussion.

    This patch enhances distance_of_time_in_words to pref...

Thursday, September 03 2009
2268 rails 2.3 session_options[:id] problem was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 6:36 PM

    Looking at your commit, it seems like I made an error when testing the bugfix. CookieStore should be deriving from Hash. I've made a patch to revert this unnece...