Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

John Pignata's latest activity

Sunday, September 27 2009
3205 [PATCH] Fix Hash#from_xml with empty hash (using REXML backend) was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 5:12 AM

    +1 verified - applies cleanly to master

3245 rewrite_asset_path should respect already existing query strings was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 4:34 AM

    -1 - rewrite_asset_path is private and probably shouldn't be enhanced directly without /good/ reason. The one call to this method I see is from compute_public_p...

3094 [PATCH] Ignorable codes(call super twice) in MemCacheStore was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 4:20 AM

    -1 Doesn't apply to master - applies to 2-3-stable but doesn't have a demonstrable impact besides a little clean-up on a maintenance branch.

3171 [PATCH] test request with Bignums in parameters raises exception was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 3:41 AM

    +1 verified that the patch works on 2-3-stable

    The file in master has been refactored however and no longer applies - however the test included in the patch run...

3257 local_request? does not detect local IPv6 connections was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 3:28 AM

    -1 on the patch as it doesn't apply

    Some thoughts on the idea -- preparing for ipv6 in general is very good.

    I don't think you should treat all traffic originat...

3212 Almost 1 second extra in time subtraction (rails 2.3.4) was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 3:22 AM

    -1 - the new behavior is desirable.

3238 mem_cache_store_test has flawed test was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 3:20 AM

    +1 verified patch applies and tests pass

1367 [PATCH] Add a NullStore to ActiveSupport::Cache was updated in Ruby on Rails
  • John Pignata
    • Title changed from [PATCH] ActiveSupport should have a "perform_caching=false" setting to [PATCH] Add a NullStore to ActiveSupport::Cache
    • Assigned user set to Michael Koziarski
    by John Pignata at 3:12 AM

    Talked to nzkoz who was of the opinion that this patch should instead be a null store that users could implement for edge cases in debugging and testing. This m...

Saturday, September 26 2009
3047 problem with cookie escaping on integration tests was updated in Ruby on Rails
3189 Add read_multi to ActiveSupport::Cache::Store was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 10:16 PM

    +1 on the change, verified that patch applies cleanly to master and tests pass