John Pignata
Not a member
John Pignata's latest activity
Sunday, September 27 2009
-
John Pignata commented at 4:34 AM-1 - rewrite_asset_path is private and probably shouldn't be enhanced directly without /good/ reason. The one call to this method I see is from compute_public_p...
-
John Pignata commented at 4:20 AM-1 Doesn't apply to master - applies to 2-3-stable but doesn't have a demonstrable impact besides a little clean-up on a maintenance branch.
-
John Pignata commented at 3:41 AM+1 verified that the patch works on 2-3-stable
The file in master has been refactored however and no longer applies - however the test included in the patch run...
-
John Pignata commented at 3:28 AM-1 on the patch as it doesn't apply
Some thoughts on the idea -- preparing for ipv6 in general is very good.
I don't think you should treat all traffic originat...
-
- Title changed from [PATCH] ActiveSupport should have a "perform_caching=false" setting to [PATCH] Add a NullStore to ActiveSupport::Cache
- Assigned user set to Michael Koziarski
Talked to nzkoz who was of the opinion that this patch should instead be a null store that users could implement for edge cases in debugging and testing. This m...
Saturday, September 26 2009
-
John Pignata commented at 10:16 PM+1 on the change, verified that patch applies cleanly to master and tests pass