Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

John Pignata's latest activity

Saturday, September 26 2009
3193 Rails 2.3.4, json gem : to_json issue was updated in Ruby on Rails
3145 .orig files override standard erb files with rails 2.3 was updated in Ruby on Rails
3047 problem with cookie escaping on integration tests was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 9:50 PM

    Elomar is correct - I can replicate on master.

    The following code is in rack-test/rack/test/cookie_jar.rb:

          def []=(name, value)
            # TODO: needs pro...
  • John Pignata
    John Pignata commented at 3:58 AM

    -1 - cannot verify this bug. Trying to verify with the following test:

    class CookieTest < ActionController::IntegrationTest
      def setup
        @cookie_data = { :r...
2982 [PATCH] Let Integer#multiple_of? accept zero as argument was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 9:23 PM

    +1 verified - both patches apply

3199 `starts/ends_with?` implementations incompatible with that of ruby 1.8.7 was updated in Ruby on Rails
  • John Pignata
    John Pignata commented at 9:23 PM

    verified the difference in implementations

    +1 patch applies cleanly to master

2553 ActionView::TemplateHandlers::ERB.erb_trim_mode= broken was updated in Ruby on Rails
3106 [PATCH] distance_of_time_in_words inaccurate for 'about 1 year ago' was updated in Ruby on Rails
  • John Pignata
    • Tag changed from action_view, date_helper, patch to action_view, bugmash, date_helper, patch
    by John Pignata at 3:36 PM

    Putting a bugmash tag on this to try to get this discussed. I know it's minor, but it's a bugaboo of mine that after an object exceeds a year in age, time_ago_i...

3035 auto_link in text_helper.rb doesn't handle some gmail URLS was updated in Ruby on Rails
3074 Remove sqlite 2 from CI setup instructions was updated in Ruby on Rails
  • John Pignata
    • Tag changed from bugmash to bugmash, master, patch
    by John Pignata at 3:29 AM

    No longer applies - fixed patch and used original header from Mike's patch to ensure patch gets credited appropriately.