Rohit Arondekar
Member of 1 project: Ruby on Rails
Rohit Arondekar's latest activity
Monday, June 21 2010
-
- Tag changed from bugmash to rails 3, activesupport, ruby1.9.2, warnings
- State changed from new to open
The warnings are now of the following types:
/home/rohit/.rvm/gems/ruby-1.9.2-head@bugmash/gems/nokogiri-1.4.2/lib/nokogiri/css/generated_parser.rb:668: warnin...
-
- State changed from open to resolved
I can't reproduce it in master either. Closing ticket assuming resolved.
-
Rohit Arondekar commented at 8:21 AMI fixed the formating of the comment made by Neeraj. Does this need more work or is the output acceptable?
-
- Milestone cleared.
- State changed from new to verified
- Assigned user set to José Valim
+1 applies cleanly, and a nice find :)
-
Rohit Arondekar commented at 2:08 AMI couldn't find any tests for Rails Runner. Does it need tests? I wouldn't mind having a go at writing some.
Sunday, June 20 2010
-
- Assigned user changed from Ryan Bigg to José Valim
Thanks David. Actually the first patch behaves like that. It will set $0 and $PROGRAM_NAME to the argument passed to runner, in case the file exists.
-
Rohit Arondekar commented at 2:39 PMOh my bad, the patch didn't have a reference to this ticket. :)
In case anyone is looking for the commit -> http://github.com/rails/rails/commit/451594784552bd...
-
Rohit Arondekar commented at 2:34 PMJose, thanks for the tip. Btw my patch didn't include the original fixing patch so that will have to be applied separately.