Activity (RSS)

+1. It would be the rails way!

Yes, this fooled me at first too.

+1

+1

+1

Much more intuitive.

+1

Slashes in the 'globbed' parameters are not escaped. The patch contains two modified tests, to illustrate the bug, and a fix.

Given this route:

map.connect ...

+1

+1

+1

Jim.

The delay is pretty normal. You generally need 3 people to vote +1 on your patch before it gets accepted. Best way of doing that is by hopping on the #rails-...

Hey,

please don't take this the wrong way, I'm not trying to bug anyone... But what are the things I should do in order to have this patch accepted into the r...

When using a belongs_to association, assigning to the foreign key attribute doesn't update the associated object (or mark a previously loaded

one as stale) un...

I think we saw assert_invalid before, and it was turned down.

We already trimmed out a bunch of superfluous assert_* response helpers. When there is a helper ...

Implementation seems a bit much. Is there anyway we can get this "flash.now["test_now"] = ">#{flash["test_now"]}<"" api as well? I rather not add yet another "...

Verified. Post a fix w/ tests and I'll get it in for ya.

$ script/generate controller admin::people
      create  app/controllers/admin
      create  app/he...

(from [bcb090c56b842a76397e0ea32f54c942fd11910e]) Calling ActiveRecord#inspect on an unloaded association won't wipe the collection [#9 state:resolved]

Signed...

I'm getting some failing tests now. I have a feeling its related to one of Pratik's deprecate instance variables commits.

  1) Failure:
test_flash(Components...

@Scott: thanks for the updated patch; I'll try to pull this in in the next couple of days.

@Dan: String#to_time has ignored the time zone since it was first a...

Yep, I agree that this is the problem. What do you think, is it appropriate to just add an include? method to Chars (or UTF8Handler)? or is there a cleaner fix...

Let me rephrase the comment above.

The proxy asks first the handler if it responds to the method, if it does not sends it to the proxied string.

Since the ha...

Problem is

>> "foo".chars.handler.respond_to?("include?")
=> true
>> "foo".chars.handler
=> ActiveSupport::Multibyte::Handlers::UTF8Handler

that is a Cla...

The docs state that "Chars objects are perfectly interchangeable with String objects as long as no explicit class checks are made."

However at least one Strin...

Here's a pastie of the code that causes LH to barf:

http://pastie.caboo.se/193322

NB: Even if I remove the "@@@ ruby" tag, it doesn't help.

I am unable to post a comment that includes my ruby source code -LH blows up. But the code example is pretty simple: implement a rescue_action_in_public and r...

Since changeset 8559, assert_response assumes it can find the instance variable @exception in the rendered template. This is not the case if the exception is ...

The session is used by the form_authenticity_token method before it is

tested to be valid. This patch moves a few lines around so that the

session is valida...

Hi,

I am on edge, and after a recent git pull started facing problems with controllers. Here's a screendump of whats happening...

amol@casper:~/projects/web/...

Yeah, I can see how it might be a PITA for small patches. I'll use attachments for future small patches.

You may want to add a note about this in the sidebar ...

Pulling one-off patches is a huge pain in the ass. It's fine for long-running, expansive branches, but for simple fixes it's far too much work. So we continue ...

In my second comment there is a link to a changeset in Git, which you can just merge into the master branch. Here is the link again:

http://github.com/aslakh...

Awesome - thanks Jeremy.

(from [2561732a08ae97fa44706a8eca4db147c4a7c286]) Some dbconsole tweaks. [#102 state:resolved]

http://github.com/rails/rails/co...

without the .exe magic the correct executable will sometimes not be found on windows. the problem is that some installations add a program.bat file alongside p...

Yeah, good question - I think it's needed. Note that it's used both for choosing a preferred binary ("mysql5" vs "mysql") and for handling the .exe thing.

Th...

Is find_cmd needed? AFAIK Windows doesn't require the .exe suffix and PATH resolution is handled by the shell already.

When eager loading a has many through association, some attributes are ignored. For example, given

class Author < AR:Base
  has_many :posts
  has_many :comm...

Exactly. After all, it seems like it 'remembers' previous keys when there no nested arrays:

<input name="telephone[][area_code]" ... />
<input name="telephon...

There's nothing to distinguish which hash keys belong to which element of the array. Looks like you expect the parser to 'remember' previously-seen hash keys a...

Geoff,

While I'm not sure whether someone would expect a string without an explicit time zone to be interpreted as UTC or the time zone set in Time.zone, I th...

If sessions were disabled using session(:off) in the application

controller, but you need sessions in another controller, session(:on)

seems intuitive as opp...

Sure, my github username is tpiekos

Good, mixed in this revision http://github.com/lifo/docrails/...

Current Rails is extremely strict about what an attribute-specific error message looks like. A human-readable attribute name is always the first word(s) of th...