This project is archived and is in readonly mode.
3.1
Progress
% Complete
Tickets Left
José Valim
2 open tickets
Closed tickets 12
-
6513simple_format behaviour changed when used in Mailer viewresolved -
6739Move TranslationHelper to I18n gem and bump I18n to 0.6.0committed -
6196[PATCH] Improve support for non-standard domain namescommitted -
6242Use Rails 3.1 `change` method in migration and model generatorscommitted -
5782Customize I18n::MissingTranslationDataresolved -
5475not_equal_to option in NumericalityValidatorstale -
5359[PATCH] Changes in autoload and some minor fixesstale -
6144Model generator doesn't honor --skip optionresolved -
5969Bump I18n and make TranslationHelper use new :rescue_format optionresolved -
5643[PATCH] Make redirect_to support blocks.resolved -
5226form_for helper don't accept 'format' optionresolved -
3760Make AR guess the inverse of an association if not specifiedhold
Sunday, March 06 2011
-
-
-
Jon Leighton commented at 6:34 PMchadoh, between the writing the original version of this patch and now I have been doing a lot of refactoring to the existing associations code in Active Record...
-
chadoh commented at 6:18 PMWhat is left to make this a reality? I'll help out. Seems like it's been done for a while now but not yet folded in.
Saturday, March 05 2011
-
- Tag changed from cli generators plugin_new to cli, generators, plugin_new
Steps to reproduce:
rvm gemset create 1.9.2@test rvm gemset use 1.9.2@test cd ~/code/rails rake install (in /Users/steve/code/rails) (in /Users/steve/code/rai...
Friday, March 04 2011
-
- State changed from new to committed
- Milestone set to 3.1
Pushed 7872cc992bac76e976334d0c20649d69aad5652e
-
- State changed from new to open
- Milestone set to 3.1
- Assigned user set to Piotr Sarnacki
- Importance changed from to Low
Hey Piotr, can you take a look at this?
Monday, February 28 2011
-
- State changed from open to verified
Verified. The patch applies to master and the provided test fails without it. :)
-
Sunday, February 27 2011
-
Jeff Kreeftmeijer commented at 5:25 PMHey Mathieu,
Nice work on your first patch! The testcase looks good too.
One thing: could you merge the testcase and the fix into one commit and supply a new pa...
-
Mathieu Ravaux commented at 5:05 AMHi Santiago, thank you for your quick reply. It's encouraging for a first contribution !
Here is the testcase:
-
- Assigned user set to Santiago Pastorino
hey Methieu we need a test case to apply the patch.
Thanks. -
Mathieu Ravaux commented at 1:34 AMHere is a patch that solves this issue.
I've tested it against Alex's app.
Saturday, February 26 2011
-
The_Lord commented at 9:56 PMThat's true. I was young and too stupid to use HTML validators when I filed this. Please mark this as invalid and call me 'idiot'. Sorry :/
-
Jonah Burke commented at 3:30 AMWhoops, here's another try, with proper formatting:
I looked into this issue, and I don't think it's a bug. As Shih-gian points out, the submit button fails to ...
-
Jonah Burke commented at 3:28 AMI looked into this issue, and I don't think it's a bug. As Shih-gian points out, the submit button fails to dim only when the form is not within a td (e.g. when...
Friday, February 25 2011
-
- State changed from open to invalid
This feature already exists in 3.0.x:
https://github.com/rails/rails/blob/3-0-stable/activerecord/lib/act...
-
-
Ben Hollis commented at 6:40 PMHey Aaron, thanks for taking another look at this. I agree that new helpers should just use capture, but what about existing helpers (and methods that use yield...
-
- State changed from open to wontfix
- Milestone set to 3.1
Alright, this bug exists because of backwards compatibility with rails 2.3. The problem is that rails 2.3 would concatenate strings with
<%erb tags. If you exa...
-
-
- State changed from new to open
This issue has been automatically marked as stale because it has not been commented on for at least three months.
The resources of the Rails core team are limit...
Thursday, February 24 2011
-
- State changed from new to committed
- Milestone set to 3.1
- Importance changed from to Low
Applied, thanks!
-
- State changed from stale to open
- Milestone set to 3.1
- Importance changed from to Low
-
- Milestone changed from 3.0.5 to 3.1
I think what we need to do is change this to do an AND in both cases for Rails 3.1. I don't like that we change it to an OR when combining only certain columns....
-
Brian Morearty commented at 12:40 AMHey, Santiago, no problem. I don't even know how you find time to do everything you do. I know reviewing patches is time-consuming. :-)
It's not a big deal if i...
-
Santiago Pastorino commented at 12:23 AMHey Brian, I'm really sorry for the delay, but I'm running out of time.
It takes a lot of time to review patches :( at least for me.Anyways the idea of this pa...
Wednesday, February 23 2011
-
Brian Morearty commented at 9:07 PMHi,
I was wondering if there's anything I can do to help push this along. I saw that a 3.0.5rc1 was pushed out today, and the original plan was to put the 'esca...
Monday, February 21 2011
-
- State changed from new to committed
- Milestone set to 3.1
- Importance changed from to Low
This is applied and pushed to master.
Sunday, February 20 2011
-
- State changed from open to committed
(from [511bf2a0505309c65bbf2ad9394e3c548762ea5d]) refactored ActiveModel::Validations::InclusionValidator#validate_each
[#6455 state:committed]
Signed-off-by: S...
-
- State changed from new to open
- Milestone set to 3.1
- Importance changed from to Low
Diego 'manxa' Carrion that looks great for me :P.
I'm pushing it.
Friday, February 18 2011
-
Brian Morearty commented at 5:25 PMHi Santiago,
Thanks again for the help! Here is a new patch for the master branch. This is what I did:
Re: your first point, you are right--the example wasn't g...
-
Brian Morearty commented at 12:54 AMThanks for taking a detailed look at it, Santiago.
+ # tag("img", {:src => "open & shut.png".html_safe})You make a good point. I'll change it to somet...
Thursday, February 17 2011
-
Santiago Pastorino commented at 11:15 PMHey Brian, first of all thanks for your work ...
About the master patch ...
+ # tag("img", {:src => "open & shut.png".html_safe})I think is not a good...
-
-
-
Santiago Pastorino commented at 6:57 PMHey Brian thanks for your work, can you please upload the patch files directly, don't wrap them in a zip is much easier for me to apply them and test.
Tuesday, February 15 2011
Sunday, February 13 2011
-
Brian Morearty commented at 10:11 PMCool, so this patch is done, tested, and ready for you to apply. The 3 helper functions mentioned above (
FormTagHelper#text_area_tag,TagHelper#content_tag, and...
No messages in this milestone.