3.1

Thanks, Jon! Looking forward to this.

Fantastic. Thanks for the update and all your hard work!

chadoh, between the writing the original version of this patch and now I have been doing a lot of refactoring to the existing associations code in Active Record...

What is left to make this a reality? I'll help out. Seems like it's been done for a while now but not yet folded in.

Steps to reproduce:

rvm gemset create 1.9.2@test
rvm gemset use 1.9.2@test
cd ~/code/rails
rake install

(in /Users/steve/code/rails)
(in /Users/steve/code/rai...

Pushed 7872cc992bac76e976334d0c20649d69aad5652e

Hey Piotr, can you take a look at this?

Verified. The patch applies to master and the provided test fails without it. :)

Sure, here it is !
Thanks for reviewing it.

Hey Mathieu,

Nice work on your first patch! The testcase looks good too.

One thing: could you merge the testcase and the fix into one commit and supply a new pa...

Hi Santiago, thank you for your quick reply. It's encouraging for a first contribution !

Here is the testcase:

hey Methieu we need a test case to apply the patch.
Thanks.

Here is a patch that solves this issue.
I've tested it against Alex's app.

That's true. I was young and too stupid to use HTML validators when I filed this. Please mark this as invalid and call me 'idiot'. Sorry :/

Whoops, here's another try, with proper formatting:

I looked into this issue, and I don't think it's a bug. As Shih-gian points out, the submit button fails to ...

I looked into this issue, and I don't think it's a bug. As Shih-gian points out, the submit button fails to dim only when the form is not within a td (e.g. when...

This feature already exists in 3.0.x:

https://github.com/rails/rails/blob/3-0-stable/activerecord/lib/act...

https://github.com/rails/rails/blob/3-0-stable/ac...

Hey Aaron, thanks for taking another look at this. I agree that new helpers should just use capture, but what about existing helpers (and methods that use yield...

Alright, this bug exists because of backwards compatibility with rails 2.3. The problem is that rails 2.3 would concatenate strings with <% erb tags. If you exa...

This issue has been automatically marked as stale because it has not been commented on for at least three months.

The resources of the Rails core team are limit...

Applied, thanks!

I think what we need to do is change this to do an AND in both cases for Rails 3.1. I don't like that we change it to an OR when combining only certain columns....

Hey, Santiago, no problem. I don't even know how you find time to do everything you do. I know reviewing patches is time-consuming. :-)

It's not a big deal if i...

Hey Brian, I'm really sorry for the delay, but I'm running out of time.
It takes a lot of time to review patches :( at least for me.

Anyways the idea of this pa...

Hi,

I was wondering if there's anything I can do to help push this along. I saw that a 3.0.5rc1 was pushed out today, and the original plan was to put the 'esca...

This is applied and pushed to master.

(from [511bf2a0505309c65bbf2ad9394e3c548762ea5d]) refactored ActiveModel::Validations::InclusionValidator#validate_each

[#6455 state:committed]

Signed-off-by: S...

Diego 'manxa' Carrion that looks great for me :P.
I'm pushing it.

Hi Santiago,

Thanks again for the help! Here is a new patch for the master branch. This is what I did:

Re: your first point, you are right--the example wasn't g...

Thanks for taking a detailed look at it, Santiago.

+      #   tag("img", {:src => "open & shut.png".html_safe})

You make a good point. I'll change it to somet...

Hey Brian, first of all thanks for your work ...

About the master patch ...

+      #   tag("img", {:src => "open & shut.png".html_safe})

I think is not a good...

and this is the patch for the master branch.

Sure. This is the patch for the 3-0-stable branch...

Hey Brian thanks for your work, can you please upload the patch files directly, don't wrap them in a zip is much easier for me to apply them and test.

seems good. Merged and pushed.

Cool, so this patch is done, tested, and ready for you to apply. The 3 helper functions mentioned above (FormTagHelper#text_area_tag, TagHelper#content_tag, and...