Activity (RSS)

I think I'd find this useful, though please don't build your API around a meta send, it's not really unnecessary and adds overhead. It's just as easy to imple...

This patch adds a :level option to validations. When a validation fails, it adds its failure notice to the Errors object indicated by the level. At this time ...

Currently selecting limited ids for eager loading associations is broken when there is a condition or an order-by based on a table that is not directly joined ...

This patch cleans up the changes that were introduced with #71. http://github.com/rails/rails/co...

It affects three areas:

1. code
2. documentation
3. whitespace

No worries, uploaded my test patch without seeing Cheah Chu Yeow's updates updates on this ticket, you can just ignore it

Here's a testcase that fails on 6a6b43 but passes on the previous commit 437f918

(you have to paste the test into 437f918- the diff doesn't apply)

Btw, now I'm more convinced that default_url_options does need some cleaning up/re-thinking!

Ack I see why that's a problem (and why it wasn't covered by existing tests nor my test in the applied patch) - default_url_options takes a single argument in ...

Since this commit, all of my named_routes are failing with

ArgumentError: wrong number of arguments (1 for 0)
        from (eval):2:in `default_url_options'

It's Sunday morning, and you sit down to work on Rails patches ... but then you see someone else has done the work for you. Life is good.

Thanks Kyle!

Steven's patch was sufficient to fix db:test:clone_structure, the only thing I use db:structure:dump for, but Jordi is right that it would produce databases th...

So has Steven's attached patch fixed the issue for you guys?

If you create an AJAX request via remote_function and specify GET as the method, the authenticity_token parameter is added even though it isn't needed. Consequ...

Fair enough. I like the convenience of being able to execute the command from any working directory in my rails project, but nonetheless, here's a patch that ...

I'd use a script instead of a rake task. Here's the script/mysql I add to most apps:

#!/usr/bin/env ruby
require 'yaml'

configs = YAML.load_file("#{File.d...

proper testing, bit of documentation.

will do one more bit of testing later.

Even simpler: rescue the bootstrapping tasks' db loading

Given that this is an edge case (trying to load up framework when db

doesn't yet exist), it makes se...

Well, a really trivial 'fix' is to just rescue observer instantiation, and log the error (patch given on right)

Given that this is a bootstrapping dependency ...

So it's trying to generate the finder sql for your has_many association, and needs the database connection in order to quote the sql,

I'm not sure how easy th...

Stack trace below

I've attached a git diff of what I had to add to a fresh rails app (6a6b439 Sun Apr 20 12:57:36 2008 +0800) to get the problem to occur.

I'...

Yes, this looks nice. Please release it.

This definitely shouldn't be in the core rails framework yet. But please release it as a gem.

This is similar to tpope's git-trac, perhaps you guys could co...

I created a set of Rake tasks based on the new patch description posted by Koz.

http://rails.lighthouseapp.com/p...

This patch adds a 'tasks' subdir for rail...

For example, say you have a model User with a column banned_at:

@user.banned_at = Time.zone.now   # => Sat, 03 May 2008 21:55:45 PDT -07:00
time_string = @us...

The patch referenced here has been rolled into #42 by request.

Alright, attaching a new patch that will handle both this ticket and that described in #86.

We do generally prefer seperate patches, but with the new git patch methods ( http://rails.lighthouseapp.com/p... ) it's a lot easier.

If you want to tie all ...

Here's the patch.

Passing blank conditions straight to ActiveRecord::Base.find works as expected, no conditions are added to the sql. The same is not true when calling find on a...

I certainly can see cases where this is required, but I'm just not convinced that it justifies a new method for us to have to maintain on an ongoing basis.

If...

(from [205750c8dead2449a23173fab0720b7701231d2a]) PostgreSQL: Connect to template1 database when creating or dropping db

• The template1 database is always ava...

I use this regularly. If it's a small patch I'd love having it in core.

nice one. +1

This is one of those great little improvements that makes sense instantly, and you use several times a day. It's especially sweet when your project has lots of...

There's no handy database analog of "script/console"; this patch addresses this by adding Rake tasks for quickly connecting to each defined database with its s...

(from [96980bd561d79824b6cb6efbcbecdcbf8785d452]) Added change_table for migrations (Jeff Dean) [#71 state:resolved]

http://github.com/rails/rails/co...

Auto-loading only works when each class is in its own file. If you want to keep all the files in one, you can always force the load with require_dependency 'co...