#1353 auto_link helper fails to parse some URLs with brackets - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#1353 ✓committed

auto_link helper fails to parse some URLs with brackets

Reported by Rich | November 11th, 2008 @ 03:57 AM | in 2.x

Found another URL that auto_link was failing on:

Anyway, fixed. Patch attached.

You flagged this item as spam.
Rich November 11th, 2008 @ 04:59 AM
After testing some more, I noticed that with or without this patch, a URL like the following gets parsed improperly. Check out the pastie.

http://pastie.org/312053

I'll put in a separate ticket.

Rich
You flagged this item as spam.
Mislav November 13th, 2008 @ 09:49 PM
Here is a patch that completely refactors auto_link_urls, fixing this and #1151, #1148 (the last remaining issues about this).
- auto_link.patch 22.3 KB
Repository November 15th, 2008 @ 05:31 PM
- State changed from “new” to “committed”
(from [4f984c9d0e66601a81cb5ae6e3b50582e6dc0c2d]) auto_link helper: add intelligent ending closing bracket handling. add new tests and reorder new ones for readability

Signed-off-by: Michael Koziarski michael@koziarski.com [#1353 state:committed] http://github.com/rails/rails/co...