This project is archived and is in readonly mode.

#2018 ✓committed
Akira Matsuda

Ruby 1.9 compat: plugin/install git://... always fails in Ruby 1.9

Reported by Akira Matsuda | February 19th, 2009 @ 07:11 PM | in 2.3.6

I found that


% script/plugin install git://...

always fails bacause FileUtils.mkdir_p does not return a string value in Ruby 1.9.

Attatched a patch to fix this problem.

Comments and changes to this ticket

  • Akira Matsuda

    Akira Matsuda March 17th, 2009 @ 06:41 AM

    • Tag changed from edge, git, plugin, ruby1.9, script to 2.3.2, edge, git, patch, plugin, ruby1.9, script

    Updated tags since I believe Rails 2.3 stable still needs this patch.

  • alan
  • Niels Ganser

    Niels Ganser July 16th, 2009 @ 10:34 AM

    • Tag changed from 2.3.2, edge, git, patch, plugin, ruby1.9, script to 2.3.2, edge, git, patch, plugin, ruby1.9, ruby19, script

    +1

    Patch applies cleanly on my system and works as advertised.

    ordimini% ./script/about
    About your application's environment
    Ruby version 1.9.1 (x86_64-linux)
    RubyGems version 1.3.1
    Rack version 1.0
    Rails version 2.3.2
    Active Record version 2.3.2
    Action Pack version 2.3.2
    Active Resource version 2.3.2
    Action Mailer version 2.3.2
    Active Support version 2.3.2

  • Nick Quaranto

    Nick Quaranto July 27th, 2009 @ 03:36 PM

    +1 to this, definitely seeing it happen here.

    % rails1.9 -v
    Rails 2.3.3
    % rails1.9 plugintest
    % cd plugintest
    % ruby1.9 script/plugin install git://github.com/thoughtbot/hoptoad_notifier.git
    Plugin not found: ["git://github.com/thoughtbot/hoptoad_notifier.git"]
    
  • Pratik

    Pratik July 27th, 2009 @ 03:41 PM

    • Milestone changed from 2.x to 2.3.4
  • Taylor luk

    Taylor luk July 29th, 2009 @ 04:08 PM

    I can confirm the same problem with Ruby 1.9 + Rails2.3

  • Peter Wagenet

    Peter Wagenet September 9th, 2009 @ 01:54 AM

    Looks like this got missed in the rush to 2.3.4 as it's still an issue. And yes, the patch works for me as well.

  • Jeremy Kemper

    Jeremy Kemper September 11th, 2009 @ 11:04 PM

    • Milestone changed from 2.3.4 to 2.3.6

    [milestone:id#50064 bulk edit command]

  • Jeremy Kemper

    Jeremy Kemper September 12th, 2009 @ 11:02 AM

    • State changed from “new” to “committed”

    2-3-stable: c5e3309bb4e63fafb363da8f7eb2364530f9f96f

    master: 3ce16b4c5fd3007d6b43364253506462e680b227

  • Owen

    Owen March 7th, 2010 @ 08:04 PM

    When is 2.3.6 to be released? This is still a problem...

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

Attachments

Referenced by

Pages