This project is archived and is in readonly mode.

#2235 ✓stale
JasonKing

savepoints in sqlite3

Reported by JasonKing | March 14th, 2009 @ 01:10 PM | in 3.x

Savepoints are supported in >= 3.6.8 sqlite - but are not implemented in the adapter.

I had them patched into #2080 but other tests seemed to be triggering the savepoints inadvertently. It's a very simple thing to add savepoint support back into the adapter, this ticket is really about tracking down the tests that fail when you do that and working out why the savepoints are getting in there, and maybe do something a little cleverer wrt how these sorts of checks are done.

I'm thinking maybe including the check in the adapter's savepoint methods, instead of the caller having to do it.

Comments and changes to this ticket

  • Jeremy Kemper

    Jeremy Kemper May 4th, 2010 @ 06:48 PM

    • Milestone changed from 2.x to 3.x
  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:35 PM

    • State changed from “new” to “open”
    • Tag changed from 2.x, adapters, savepoint, sqlite3, sqlite_adapter to 2x, adapters, savepoint, sqlite3, sqlite_adapter

    This issue has been automatically marked as stale because it has not been commented on for at least three months.

    The resources of the Rails core team are limited, and so we are asking for your help. If you can still reproduce this error on the 3-0-stable branch or on master, please reply with all of the information you have about it and add "[state:open]" to your comment. This will reopen the ticket for review. Likewise, if you feel that this is a very important feature for Rails to include, please reply with your explanation so we can consider it.

    Thank you for all your contributions, and we hope you will understand this step to focus our efforts where they are most helpful.

  • Santiago Pastorino

    Santiago Pastorino February 2nd, 2011 @ 04:35 PM

    • State changed from “open” to “stale”

Create your profile

Help contribute to this project by taking a few moments to create your personal profile. Create your profile »

<h2 style="font-size: 14px">Tickets have moved to Github</h2>

The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>

People watching this ticket

Pages