This project is archived and is in readonly mode.
complex versions in config.gem fails
Reported by jeff | May 20th, 2008 @ 07:54 PM
adding something like:
config.gem "json", :version => ['>= 1.1.2', '< 1.1.3']
in environment.rb fails with: Illformed requirement [">= 1.1.2, < 1.1.3"]
patch & test changes attached
Comments and changes to this ticket
-
jeff May 21st, 2008 @ 06:03 PM
this initial patch actually caused problems with gem:unpack / gem:install, unless you use code from the unpack_command.rb in rubygems to do a search prior to running unpack / install
Gem::SourceIndex.from_installed_gems.search(/\A#{gemname}\z/, version_req)
selected = specs.sort_by { |s| s.version }.last
secondary patch attached
-
Pratik May 22nd, 2008 @ 12:23 PM
- Assigned user set to “Rick”
Could you please use git-format-path ?
Thanks.
-
-
jeff May 22nd, 2008 @ 07:22 PM
- no changes were found...
-
Lee Marlow July 11th, 2008 @ 12:39 AM
- Tag set to “2.1, bug, edge, gem, initialization, patch, railties, tested”
+1
This fixed some problems for me when using the "~>" gem requirement operator. I'm attaching an updated patch that should apply to edge and 2-1-stable.
-
Tiago Macedo July 11th, 2008 @ 03:58 AM
This patch (http://rails.lighthouseapp.com/p... addresses a different issue in the "same" code, perhaps they should be merged into a single patch?
-
josh October 28th, 2008 @ 04:24 PM
- State changed from “new” to “stale”
Staling out, please reopen if this is still a problem.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
People watching this ticket
jeff
josh
Lee Marlow
Pratik
Rick
Ripta Pasay
Rob Sanheim
Attachments
Referenced by
-
1128
Fix config.gem bugs and add more tests
incorporates, via using the gem loader for frozen gems, f...