Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

complex versions in config.gem fails

#227

adding something like:

config.gem "json", :version => ['>= 1.1.2', '< 1.1.3']

in environment.rb fails with: Illformed requirement [">= 1.1.2, < 1.1.3"]

patch & test changes attached

Reported by jeff · May 20th, 2008 @ 07:54 PM

State: stale
Milestone: none
Assigned to: Rick Rick
Importance: none

Activity

  1. jeff
    jeff

    this initial patch actually caused problems with gem:unpack / gem:install, unless you use code from the unpack_command.rb in rubygems to do a search prior to running unpack / install

    Gem::SourceIndex.from_installed_gems.search(/\A#{gemname}\z/, version_req)

    selected = specs.sort_by { |s| s.version }.last

    secondary patch attached

    May 21st, 2008 @ 06:03 PM

  2. Pratik
    Pratik
    • Assigned user set to Rick

    Could you please use git-format-path ?

    Thanks.

    May 22nd, 2008 @ 12:23 PM

  3. jeff
    jeff

    recreated patch using git

    May 22nd, 2008 @ 03:25 PM

  4. jeff
    jeff

    May 22nd, 2008 @ 07:22 PM

  5. Lee Marlow
    Lee Marlow
    • Tag set to 2.1, bug, edge, gem, initialization, patch, railties, tested

    +1

    This fixed some problems for me when using the "~>" gem requirement operator. I'm attaching an updated patch that should apply to edge and 2-1-stable.

    July 11th, 2008 @ 12:39 AM

  6. Tiago Macedo
    Tiago Macedo

    This patch (http://rails.lighthouseapp.com/p... addresses a different issue in the "same" code, perhaps they should be merged into a single patch?

    July 11th, 2008 @ 03:58 AM

  7. josh
    josh
    • State changed from new to stale

    Staling out, please reopen if this is still a problem.

    October 28th, 2008 @ 04:24 PM