#2439 [PATCH] ActionController::Integration::Session no longer mangles multiparameter attribute params when processing multipart requests - Ruby on Rails

Type	To find
responsible:me	tickets assigned to you
tagged:"@high"	tickets tagged @high
milestone:next	tickets in the upcoming milestone
state:invalid	tickets with the state invalid
created:"last week"	tickets created last week
sort:number, importance, updated	tickets sorted by #, importance or updated
Combine keywords for powerful searching.
Use advanced searching »

This project is archived and is in readonly mode.

#2439 new

[PATCH] ActionController::Integration::Session no longer mangles multiparameter attribute params when processing multipart requests

Reported by Steven Luscher | April 7th, 2009 @ 04:46 AM | in 3.0.6

Fixed what I thought was a bug in Webrat, but turned out to be a bug in Rails.

Turns out, if you try:


post :update, :"foo(1i)" => 1980, :"foo(2i)" => 2, :"foo(3i)" => 27

…everything works as you would expect. The moment you make that post multipart, though, by adding a file to the mix:


post :update, :"foo(1i)" => 1980, :"foo(2i)" => 2, :"foo(3i)" => 27, :file => fixture_file_upload("birthday_suit.jpg", "image/jpg")

…params[:"foo(1i)"] unexpectedly becomes params[:"foo%281i%29"] as the curved brackets get escaped.

Patch attached!

Comments and changes to this ticket

You flagged this item as spam.
Steven Luscher April 7th, 2009 @ 04:54 AM
- Tag changed from “action_controller, integration_test” to “action_controller, integration_test, patch”
You flagged this item as spam.
Mike Enriquez May 10th, 2009 @ 01:56 AM
- Assigned user cleared.
I think there's something funky with the patch. You probably meant this
```
k = first ? key.to_s : "[#{key.to_s}]"
```
instead of
```
k = first ? key.to_s : "[key.to_s}]"
```
You flagged this item as spam.
Steven Luscher May 10th, 2009 @ 03:59 AM
- Assigned user set to “Michael Koziarski”
Beautiful typo. Patched patch attached!
- patch_multipart_post_with_multiparameter_attribute_parameters.diff 3.1 KB
Michael Koziarski June 9th, 2009 @ 09:15 AM
- Milestone cleared.
Applied to 2-3-stable, moving to 3.0.

This patch doesn't apply cleanly to master, is it no longer needed or?
Dan Pickett April 21st, 2010 @ 02:31 AM
We've added the test cases to Rails 3 to verify that this errant behavior does not exist on master

Patch attached
- 2439_rails_3.patch 2.4 KB
Dan Pickett April 21st, 2010 @ 02:31 AM
FYI I worked with the Boston.rb team on this!
Dan Pickett May 9th, 2010 @ 06:17 PM
- Tag changed from “action_controller, integration_test, patch” to “action_controller, bugmash, integration_test, patch”
Jeremy Kemper August 30th, 2010 @ 04:10 AM
- Milestone cleared.
- Importance changed from “” to “Low”
[bulk edit]
Jeremy Kemper October 15th, 2010 @ 11:01 PM
- Milestone set to “3.0.2”
[bulk edit]
Santiago Pastorino November 15th, 2010 @ 09:15 PM
- Milestone cleared.
[bulk edit]
Santiago Pastorino February 12th, 2011 @ 09:58 PM
- Milestone set to “3.0.5”
[bulk edit]
Santiago Pastorino February 27th, 2011 @ 03:15 AM
- Milestone changed from “3.0.5” to “3.0.6”
[bulk edit]
You flagged this item as spam.
belstaff bag March 25th, 2011 @ 11:50 AM
Chickens slaughtered in the United States