Rails Ruby on Rails → 2.x

Comments and changes to this ticket

• You flagged this item as spam.
  

  Daniel Guettler May 25th, 2009 @ 03:42 PM

  I can confirm this bug in the current gem version. However it has already been fixed by this commit: http://github.com/rails/rails/commit/a70c78177a564c2f2cd09846a5e7ab...

• 

  CancelProfileIsBroken May 25th, 2009 @ 03:56 PM

  • State changed from “new” to “resolved”

• You flagged this item as spam.
  

  Andrew Kaspick May 25th, 2009 @ 07:34 PM

  Is "rake rails:freeze:edge" supposed to pull a copy of rails with this fix?

  I grabbed edge, but am still experiencing the issue.

• You flagged this item as spam.
  

  Andrew Kaspick May 25th, 2009 @ 08:44 PM

  Looks like the rake command has the "fix", but the bug still exists because :autosave is true even if I set it to false with...

  has_one :contact, :autosave => false
  

• You flagged this item as spam.
  

  Andrew Kaspick May 25th, 2009 @ 08:49 PM

  My error... the case outlined in this ticket is resolved.

  Reading the code/docs here I see...

  Note that the :autosave option is automatically enabled on every
  

  # association that accepts_nested_attributes_for is used for.
  

  This is the situation in my production code; I'm using ccepts_nested_attributes_for.

  Should :autosave => false on the association not override the automatica enabling of the :autosave option in this case?

• You flagged this item as spam.
  

  Andrew Kaspick May 25th, 2009 @ 08:59 PM

  • Tag changed from “2-3-stable, after_create, associations, bug, has_one” to “2-3-stable, accepts_nested_attributes_for, after_create, associations, bug, has_one”

  Sorry for all the messages. I've removed the use of accepts_nested_attributes_for in my code and now things work.

  The issue is shown with this modification to code...

  class Account < ActiveRecord::Base
    has_one :contact
  
    accepts_nested_attributes_for :contact
  
    def after_create
      create_contact
    end
  end
  

  Note the addition of accepts_nested_attributes_for

  Should I open a new ticket for this? If I'm manually calling the assocation code with "create_contact" and not going through the accepts_nested_attributes_for avenue for creating the association, this seems to be "unexpected" behaviour.

• 

  CancelProfileIsBroken May 25th, 2009 @ 09:14 PM

  Is that any different from what was fixed in #2249 ?

• You flagged this item as spam.
  

  Mike Breen May 25th, 2009 @ 09:16 PM

  Andrew,

  I believe that this has been resolved.

• You flagged this item as spam.
  

  Andrew Kaspick May 25th, 2009 @ 09:27 PM

  It's a similar situation, but when using accepts_nested_attributes_for, line 211 in nested_attributes.rb causes the unexpected behaviour...

  reflection.options[:autosave] = true
  

  :autosave should not be true in my opinion for the example outlined. I spent a good number of hours trying to figure out why the association record was being saved even though it was invalid. Invalid records should not be saved to the DB.

  If I remove the accepts_nested_attributes_for line in my revised example, the issue goes away.

• You flagged this item as spam.
  

  Daniel Guettler May 26th, 2009 @ 04:01 AM

  Ok, this is a rather engineered example in my view. You probably want to either have accepts_nested_attributes OR a manual create_after.
  Anyway so here what's happening:

  1) All validations for Account and associated Contact run and pass, Contact is nil at this point so no validations needed.

  2) Account is created etc.

  3) Callbacks run
  3.1) after_create callback is executed and tries to create a new Contact which in this step fails since validation doesn't pass. Account.contact is NOT nil anymore after this but contains the new record with validation errors.
  3.2) after_save callback is executed which will execute the callback added by autosave. It will create the Contact which was initialized in 3.1 without any further validations since it is assumed that the validations added by autosave have been run successfully.

  To avoid this one possible solution would be to not call save(false) in autosave_association.rb in order to avoid invalid records from being saved into the database.

• You flagged this item as spam.
  

  Andrew Kaspick May 26th, 2009 @ 04:46 AM

  I've actually modified my code to...

  def after_create
    c = build_contact
    c.save false
  end
  

  So yes, the original example given now could be looked upon as "engineered" as it doesn't check for errors anyway. I guess the "surprise" of having an object with errors being saved to the database as being the main issue here since it's what started my rat race of trying to find out why that was happening in the first place. A case of violating the principle of least surprise (POLS) I'd say.

  Thanks for the input.