This project is archived and is in readonly mode.
[PATCH] Let Integer#multiple_of? accept zero as argument
Currently Integer#multiple_of? delegates to %, and so raises a division by zero exception if the argument is zero.
But that case is of course well-defined: no integer is multiple of zero except zero. This little patch adds that.
-
let_multiple_of_accept_zero.diff
1.65 KB
-
Peter WagenetLooks good to me.
-
CancelProfileIsBroken
- Tag changed from activesupport, integer, multiple_of to activesupport, bugmash, integer, multiple_of
-
Robert Rouse
The current patch does not apply on the 2.3 stable branch. I have reformatted the patch for the branch.
Attached is the patch.
-
let_multiple_of_take_zero.diff
1.65 KB
-
-
Robert Rouse
I should say the original patch would apply to master.
-
Elad Meidar
+1 verified and both patches apply cleanly.
-
Pat Allan- Tag changed from activesupport, bugmash, integer, multiple_of to activesupport, bugmash, bugmash-review, integer, multiple_of
Just tested on 2.3 and master, all good. +1 Verified.
-
Josh Sharpe- Title changed from Let Integer#multiple_of? accept zero as argument to [PATCH] Let Integer#multiple_of? accept zero as argument
+1 both patches work
-
sr.iniv.t
+1 verified.
Xavier's patch applies on 2-3-stable and all tests pass. Robert's patch didn't apply for me for whatever reason, don't know what i was doing wrong.
-
Robert Rouse
sr.iniv.t:
You probably didn't have the 2-3-stable branch checked out when you applied the patch I attached. The original patch will apply on master. Mine applies on 2-3-stable. They need to be different because master adds methods to the Integer class directly. 2-3-stable uses a module.
-
John Pignata
+1 verified - both patches apply
-
sr.iniv.t
Robert:
Errr, sorry about the mix up. I was indeed trying Xavier's patch on master. I applied your patch to 2-3-stable and the patch applies fine. :-)
-
Blue Box Chris
+1 patch applies cleanly
-
qmx
+1 patch applies cleanly
-
Matías Floresverified the issue and patch applied cleanly
-
Kieran P+1 verified patches apply cleanly.
-
CancelProfileIsBroken
- Tag changed from activesupport, bugmash, bugmash-review, integer, multiple_of to activesupport, bugmash-review, integer, multiple_of
-
Xavier Noria- Assigned user set to Jeremy Kemper
Updates the patch so that it applies after the recent 1.8.6 cleanup in AS. New file is let_multiple_of_accept_zero_2.diff.
-
Repository
- State changed from new to committed
(from [7a2554d9a35545ad24937f04c6416df3ed3f26d9]) Let Integer#multiple_of? accept zero as argument
[#2982 [PATCH] Let Integer#multiple_of? accept zero as argument state:committed]
Signed-off-by: Jeremy Kemper jeremy@bitsweat.net
http://github.com/rails/rails/commit/7a2554d9a35545ad24937f04c6416d... -
Rizwan Reza- Tag changed from activesupport, bugmash-review, integer, multiple_of to activesupport, integer, multiple_of