This project is archived and is in readonly mode.
Active Record Helper form(record_name, options={}) fails (but simple fix)
Reported by jeffp | September 4th, 2009 @ 09:20 PM | in 3.0.6
Location: actionpack-2.3.4/lib/action_view/helpers/active_record_helpers.rb
Line with error
contents = form_tag({:action => action}, :method
=>(options[:method] || 'post'), :encrypt => ...
Fix
contents = form_tag(action, :method=>(options[:method] ||
'post'), :encrypt => ...
Description
The 'action' variable has already been cast as a URL with url_for a
few lines before this. It is not proper to use it as a value for
:action in a hash when sending it to form_tag.
Comments and changes to this ticket
-
jeffp September 4th, 2009 @ 09:23 PM
- Tag changed from “2.3.3, 2.3.4” to “2.3.3, 2.3.4, actionpack, helpers”
-
CancelProfileIsBroken September 25th, 2009 @ 12:33 PM
- Tag changed from “2.3.3, 2.3.4, actionpack, helpers” to “2.3.3, 2.3.4, actionpack, bugmash, helpers”
-
Daniel Hofstetter September 27th, 2009 @ 09:57 AM
I've attached a patch for this issue. active_record_helper.rb.diff is for 2-3-stable, and active_model_helper.rb.diff is for master.
-
Daniel Hofstetter September 27th, 2009 @ 09:59 AM
- Tag changed from “2.3.3, 2.3.4, actionpack, bugmash, helpers” to “2.3.3, 2.3.4, actionpack, bugmash, bugmash-patch, bugmash-review, helpers”
-
hsume2 (Henry) September 27th, 2009 @ 10:28 AM
+1, verified in master and 2-3-stable. (master patch applies cleanly to both)
-
CancelProfileIsBroken September 27th, 2009 @ 12:00 PM
- Tag changed from “2.3.3, 2.3.4, actionpack, bugmash, bugmash-patch, bugmash-review, helpers” to “2.3.3, 2.3.4, actionpack, bugmash-review, helpers”
-
Rizwan Reza May 15th, 2010 @ 06:45 PM
- Milestone cleared.
- Tag changed from “2.3.3, 2.3.4, actionpack, bugmash-review, helpers” to “2.3.3, 2.3.4, actionpack, bugmash, helpers”
- State changed from “new” to “open”
-
-
Jeremy Kemper August 30th, 2010 @ 04:10 AM
- Milestone cleared.
- Importance changed from “” to “Low”
-
-
-
Dan Pickett February 8th, 2011 @ 02:56 AM
it looks like the patches were lost for some reason (I can't access them)
-
-
Santiago Pastorino February 27th, 2011 @ 03:15 AM
- Milestone changed from “3.0.5” to “3.0.6”
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile »
<h2 style="font-size: 14px">Tickets have moved to Github</h2>
The new ticket tracker is available at <a href="https://github.com/rails/rails/issues">https://github.com/rails/rails/issues</a>
Dan Pickett
Jeff Kreeftmeijer
Jeremy Kemper
Rizwan Reza