Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

This project is archived and is in readonly mode.

Remove needless call to initializers

#3892

In the initializers method for Rails::Application, the final line returns the collection of initializers, as the line before it would do as well. This patch removes that final line and will probably speed up the boot process of Rails by 0.000000000000001%.

Reported by Ryan Bigg · February 7th, 2010 @ 11:53 PM

State: resolved
Milestone: 3.1
Assigned to: Santiago Pastorino Santiago Pastorino
Importance: Low

Activity

  1. Eadz
    Eadz

    Thankyou for this patch. I have been waiting for this for so long! I hope this can make it into 3.0 :p

    February 8th, 2010 @ 12:25 AM

  2. Rohit Arondekar
    Rohit Arondekar
    • State changed from new to open
    • Assigned user set to Ryan Bigg
    • Importance changed from to Low

    I don't know how relevant this still is but that line is still there.

    But do you think this needs tests? If not assign it to Santiago.

    October 8th, 2010 @ 02:16 AM

  3. Aditya Sanghi
    Aditya Sanghi

    +1 i say. Why? Makes Rails Scale. :D

    October 8th, 2010 @ 07:07 AM

  4. Santiago Pastorino
    Santiago Pastorino
    • Milestone set to 3.1
    • Assigned user changed from Ryan Bigg to Santiago Pastorino

    Can you Ryan rebase this one, thx.

    October 8th, 2010 @ 11:40 AM

  5. Rohit Arondekar
  6. Repository
    Repository
    • State changed from open to resolved

    (from [5826c1730720e8b11f7cc82831a1c76427e9ada2]) Remove the final initializers since initializers += will return it anyway. [#3892 Remove needless call to initializers state:resolved]

    Signed-off-by: Santiago Pastorino santiago@wyeworks.com
    http://github.com/rails/rails/commit/5826c1730720e8b11f7cc82831a1c7...

    October 8th, 2010 @ 06:34 PM